#8761: update internal/external naming from brick to package in the Workshop

[twschiller]

What does this PR do?

• Closes Update internal/external naming from brick to package in Workshop #8761
• Updates internal/external naming from brick to package. (Because not everything is a "brick" anymore)

Remaining Work

• Fix broken playwright tests - having trouble with authentication fixture when running locally

Discussion

• package is a reserved keyword in JS. So uses a modifier, e.g., editablePackage, packageMetadata, etc. where appropriate

Demo

Future Work

• Split/Rename Metadata to something more informative of how it's actually used, e.g., PackageInstance: #8769: introduce PackageInstance type to disambiguate from Metadata definition/instance use cases #8770
• Rename BrickIcon to PackageIcon because it's also used for starter bricks/integrations

For more information on our expectations for the PR process, see the
code review principles doc

[twschiller]

🐛 Bug fix where showSearchFilter was never being used. I'm surprised it wasn't flagged as dead code

[github-actions]

Playwright test results

 83 passed
 1 flaky
 2 skipped

Details

 Open report ↗︎
 86 tests across 30 suites
 14 minutes
 165acb1

Flaky tests

edge › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

[codecov]

Codecov Report

Attention: Patch coverage is 53.07692% with 61 lines in your changes missing coverage. Please review.

Project coverage is 74.23%. Comparing base (8318d74) to head (165acb1).
Report is 23 commits behind head on main.

Files	Patch %	Lines
.../extensionConsole/pages/packageEditor/EditPage.tsx	0.00%	18 Missing ⚠️
...rc/extensionConsole/pages/packageEditor/Editor.tsx	40.74%	16 Missing ⚠️
...es/packageEditor/referenceTab/PackageReference.tsx	31.57%	13 Missing ⚠️
...xtensionConsole/pages/packageEditor/CreatePage.tsx	0.00%	3 Missing ⚠️
...pages/packageEditor/referenceTab/PackageResult.tsx	50.00%	3 Missing ⚠️
...ionConsole/pages/workshop/EditablePackagesCard.tsx	57.14%	3 Missing ⚠️
...ionConsole/pages/packageEditor/useSubmitPackage.ts	75.00%	2 Missing ⚠️
...pages/packageEditor/referenceTab/PackageDetail.tsx	90.90%	1 Missing ⚠️
...c/extensionConsole/pages/workshop/WorkshopPage.tsx	95.45%	1 Missing ⚠️
src/store/workshopSlice.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8762      +/-   ##
==========================================
- Coverage   74.24%   74.23%   -0.02%     
==========================================
  Files        1332     1332              
  Lines       40817    40857      +40     
  Branches     7634     7640       +6     
==========================================
+ Hits        30306    30330      +24     
- Misses      10511    10527      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[twschiller]

We'll want to rename this directory/module in a future PR given that it performs package search (e.g., for integration definitions), not just brick search

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.