Change modeling of Literals in the AST remove ambiguity #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-ion-doc #517 +/- ##
===============================================
+ Coverage 80.70% 80.75% +0.04%
===============================================
Files 88 88
Lines 19409 19483 +74
Branches 19409 19483 +74
===============================================
+ Hits 15665 15734 +69
- Misses 3324 3326 +2
- Partials 420 423 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Conformance comparison report
Number passing in both: 5564 Number failing in both: 833 Number passing in Base (75ffa06) but now fail: 0 Number failing in Base (75ffa06) but now pass: 0 |
jpschorr
requested review from
alancai98 and
am357
and removed request for
alancai98
|
Follow-up #518 to fix the |
alancai98
approved these changes
Nov 18, 2024
jpschorr
added a commit
that referenced
this pull request
Dec 5, 2024
Change parsing and AST-modeling of literals to not share AST structures with non-scalar expressions.
jpschorr
added a commit
that referenced
this pull request
Dec 5, 2024
* Change Lexing/Parsing of embedded docs to not eagerly validate (#507) This changes the lexer and parser to pass through strings enclosed in backticks un-parsed. (At current, these documents are parsed during lowering). Since embedded documents may themselves contain backticks, beginning and ending delimiters consist of an arbitrary odd numbers of backticks (e.g., `` ` ``, `` ``` ``, `` ````` `` etc.) that must be paired (e.g., `` `$ion_data_here::[]` ``, `` ```$ion_data_here::[ $string_with_embedded_backtick:"`" ]``` ``, etc.). As opening and closing delimiters are required to be odd in count of backticks, a contiguous string of backticks that is even is interpreted as an empty document. * Behavior-preserving refactor of `Value` into a module. (#509) * Behavior-preserving refactor of Value into a module. (#510) * Change modeling of Literals in the AST remove ambiguity (#517) Change parsing and AST-modeling of literals to not share AST structures with non-scalar expressions. * Change modeling of boxed ion literals to be lazy until evaluator. (#519) Changes the logical plan to have a distinct `Lit` type to hold literals instead of embedded `Value` * Refactor lifetimes for new rust warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change parsing and AST-modeling of literals to not share AST structures with non-scalar expressions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.