-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor Value & Enable Lazy Ion literals. (#523)
* Change Lexing/Parsing of embedded docs to not eagerly validate (#507) This changes the lexer and parser to pass through strings enclosed in backticks un-parsed. (At current, these documents are parsed during lowering). Since embedded documents may themselves contain backticks, beginning and ending delimiters consist of an arbitrary odd numbers of backticks (e.g., `` ` ``, `` ``` ``, `` ````` `` etc.) that must be paired (e.g., `` `$ion_data_here::[]` ``, `` ```$ion_data_here::[ $string_with_embedded_backtick:"`" ]``` ``, etc.). As opening and closing delimiters are required to be odd in count of backticks, a contiguous string of backticks that is even is interpreted as an empty document. * Behavior-preserving refactor of `Value` into a module. (#509) * Behavior-preserving refactor of Value into a module. (#510) * Change modeling of Literals in the AST remove ambiguity (#517) Change parsing and AST-modeling of literals to not share AST structures with non-scalar expressions. * Change modeling of boxed ion literals to be lazy until evaluator. (#519) Changes the logical plan to have a distinct `Lit` type to hold literals instead of embedded `Value` * Refactor lifetimes for new rust warnings
- Loading branch information
Showing
36 changed files
with
2,055 additions
and
1,611 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
a07bdfc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PartiQL (rust) Benchmark
arith_agg-avg
765417
ns/iter (± 9720
)790105
ns/iter (± 11027
)0.97
arith_agg-avg_distinct
857628
ns/iter (± 2290
)866700
ns/iter (± 2429
)0.99
arith_agg-count
823325
ns/iter (± 14147
)833098
ns/iter (± 8364
)0.99
arith_agg-count_distinct
849976
ns/iter (± 1321
)868307
ns/iter (± 4014
)0.98
arith_agg-min
825972
ns/iter (± 45164
)840261
ns/iter (± 5673
)0.98
arith_agg-min_distinct
852656
ns/iter (± 2511
)870972
ns/iter (± 40419
)0.98
arith_agg-max
830428
ns/iter (± 5999
)844735
ns/iter (± 6067
)0.98
arith_agg-max_distinct
860720
ns/iter (± 30809
)878921
ns/iter (± 22966
)0.98
arith_agg-sum
826283
ns/iter (± 12568
)840506
ns/iter (± 7062
)0.98
arith_agg-sum_distinct
856047
ns/iter (± 5027
)868109
ns/iter (± 11415
)0.99
arith_agg-avg-count-min-max-sum
995733
ns/iter (± 12537
)993679
ns/iter (± 4817
)1.00
arith_agg-avg-count-min-max-sum-group_by
1221238
ns/iter (± 30151
)1261944
ns/iter (± 11475
)0.97
arith_agg-avg-count-min-max-sum-group_by-group_as
1843394
ns/iter (± 7066
)1869825
ns/iter (± 11386
)0.99
arith_agg-avg_distinct-count_distinct-min_distinct-max_distinct-sum_distinct
1202863
ns/iter (± 32389
)1228616
ns/iter (± 6146
)0.98
arith_agg-avg_distinct-count_distinct-min_distinct-max_distinct-sum_distinct-group_by
1478093
ns/iter (± 36300
)1515867
ns/iter (± 115785
)0.98
arith_agg-avg_distinct-count_distinct-min_distinct-max_distinct-sum_distinct-group_by-group_as
2072542
ns/iter (± 9664
)2129616
ns/iter (± 9534
)0.97
parse-1
6165
ns/iter (± 25
)6130
ns/iter (± 230
)1.01
parse-15
51563
ns/iter (± 204
)51127
ns/iter (± 2468
)1.01
parse-30
98311
ns/iter (± 355
)99090
ns/iter (± 368
)0.99
compile-1
4246
ns/iter (± 34
)4399
ns/iter (± 26
)0.97
compile-15
30444
ns/iter (± 118
)31298
ns/iter (± 342
)0.97
compile-30
63588
ns/iter (± 140
)64065
ns/iter (± 3328
)0.99
plan-1
70683
ns/iter (± 180
)70921
ns/iter (± 1513
)1.00
plan-15
1101877
ns/iter (± 15617
)1102491
ns/iter (± 48335
)1.00
plan-30
2204988
ns/iter (± 16988
)2193118
ns/iter (± 10706
)1.01
eval-1
11996073
ns/iter (± 261515
)12146862
ns/iter (± 99488
)0.99
eval-15
76529036
ns/iter (± 455327
)76690162
ns/iter (± 364929
)1.00
eval-30
146551997
ns/iter (± 516782
)146088058
ns/iter (± 456686
)1.00
join
9914
ns/iter (± 122
)10025
ns/iter (± 177
)0.99
simple
2486
ns/iter (± 6
)2569
ns/iter (± 5
)0.97
simple-no
460
ns/iter (± 1
)508
ns/iter (± 1
)0.91
numbers
57
ns/iter (± 0
)57
ns/iter (± 0
)1
parse-simple
961
ns/iter (± 4
)971
ns/iter (± 4
)0.99
parse-ion
2621
ns/iter (± 5
)2601
ns/iter (± 92
)1.01
parse-group
7912
ns/iter (± 24
)8076
ns/iter (± 280
)0.98
parse-complex
20359
ns/iter (± 197
)21305
ns/iter (± 71
)0.96
parse-complex-fexpr
27825
ns/iter (± 93
)28541
ns/iter (± 1102
)0.97
This comment was automatically generated by workflow using github-action-benchmark.