Refactor Value & Enable Lazy Ion literals.

[jpschorr]

Merges the following previously PRed changes to main:

• Change Lexing/Parsing of embedded docs to not eagerly validate #507
• Behavior-preserving refactor of Value into a module. #509
• Behavior-preserving refactor of Value into a module. #510
• Change modeling of Literals in the AST remove ambiguity #517
• Change modeling of boxed ion literals to be lazy until evaluator. #519

Also fixes a few minor lifetime warnings from newer versions of rust/clippy.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Attention: Patch coverage is 81.47448% with 196 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (4a4b143) to head (2c7cb62).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
partiql-value/src/value.rs	81.12%	46 Missing and 1 partial ⚠️
partiql-logical/src/util.rs	61.53%	36 Missing and 4 partials ⚠️
partiql-value/src/value/math.rs	79.02%	30 Missing ⚠️
partiql-logical-planner/src/lower.rs	77.27%	12 Missing and 3 partials ⚠️
partiql-value/src/bindings.rs	40.00%	15 Missing ⚠️
partiql-logical-planner/src/typer.rs	0.00%	9 Missing ⚠️
partiql-parser/src/parse/parse_util.rs	83.67%	5 Missing and 3 partials ⚠️
partiql-value/src/value/iter.rs	76.66%	7 Missing ⚠️
partiql-value/src/sort.rs	77.77%	6 Missing ⚠️
partiql-value/src/util.rs	76.19%	5 Missing ⚠️
... and 7 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   80.76%   80.75%   -0.02%     
==========================================
  Files          80       89       +9     
  Lines       19405    19593     +188     
  Branches    19405    19593     +188     
==========================================
+ Hits        15673    15822     +149     
- Misses       3311     3352      +41     
+ Partials      421      419       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Conformance comparison report

	Base (4a4b143)	a11496b	+/-
% Passing	86.97%	86.90%	-0.06%
✅ Passing	5591	5587	-4
❌ Failing	838	842	4
🔶 Ignored	0	0	0
Total Tests	6429	6429	0

Number passing in both: 5587

Number failing in both: 838

Number passing in Base (4a4b143) but now fail: 4

Number failing in Base (4a4b143) but now pass: 0

⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see

• partiql_tests::fail::static_analysis::primitives::primitives::functions::lower::invalid_function_args::lower::lower_wrong_type_of_arguments_param
• partiql_tests::fail::static_analysis::primitives::primitives::functions::upper::invalid_function_args::upper::upper_wrong_type_of_arguments_param
• partiql_tests::fail::static_analysis::primitives::primitives::functions::char_length::invalid_function_args::char_length::char_length_wrong_types_in_
• partiql_tests::fail::static_analysis::primitives::primitives::functions::char_length::invalid_function_args::char_length::character_length_wrong_types_in_

[alancai98]

Looks like there's a slight regression in some conformance tests. Could take a brief look at those

[jpschorr]

Looks like there's a slight regression in some conformance tests. Could take a brief look at those

They are changes to static analysis tests. In making ion data lazy, the ion parsing is no longer happening at a time that triggers the failure for these tests.

e.g.,

fail_semantics("char_length(`()`)");

No longer immediately errors, since the () isn't parsed prior to lowering to a logical plan anymore. I'll either change the way semantics tests are validated as part of the larger lazy document initiative, or tests like these will be changed, as 'semantic' is a fuzzy line between syntax and evaluation anyway.