Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump system version to 1.0.4 #4437

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Bump system version to 1.0.4 #4437

merged 1 commit into from
Nov 7, 2023

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Nov 4, 2023

In preparation for the next release, bump the system version.

@iliana
Copy link
Contributor Author

iliana commented Nov 5, 2023

I realized a few hours ago that this change does have the effect of also bumping all our control plane component versions to "4.0.0". This is probably not ideal.

I might prefer to change this to keep the version stamped into zones and whatnot at the current version, and replace the system version in the tuf-repo.sh job.

@askfongjojo
Copy link

How about we make it v1.0.4 first? It should not result in confusion as long as we are good about linking this to the marketing version in our internal documentation.

@iliana
Copy link
Contributor Author

iliana commented Nov 6, 2023

As in, control plane components versioned v1.0.4, while still adjusting the system version to v4.0.0?

@askfongjojo
Copy link

Sorry for being unclear. Just bumping the system version to 1.0.4, exactly like how we did it for 1.0.3.

@iliana
Copy link
Contributor Author

iliana commented Nov 6, 2023

OK. I'll adjust this PR and we'll work out the finer details.

Content removed from repo description

It is my understanding that we're now describing system versions to customers as integers, but the system_version field we have across the control plane is a SemverVersion, which means current software is going to continue expecting a semver unless/until we change that.

It is simple enough to convert an integer version to semver (just add .0.0!™), and we can still trivially stamp the commit hash into our CI-generated repos as we do now. Future release engineering work will replace the system version with a non-CI-stamped one when signing updates.

@iliana iliana changed the title Bump system version to 4 (aka 4.0.0) Bump system version to 1.0.4 Nov 6, 2023
@iliana iliana merged commit 5b6f7df into main Nov 7, 2023
20 checks passed
@iliana iliana deleted the iliana/four branch November 7, 2023 19:02
@askfongjojo
Copy link

For the record - LGTM after all the back-and-forth.

@iliana iliana mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants