Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set version to 5.0.0 #4566

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Set version to 5.0.0 #4566

merged 1 commit into from
Dec 5, 2023

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Nov 28, 2023

Last time around I raised a concern about jumping to x.0.0 but we resolved that in the next updates meeting, and decided it's fine for all the inner control plane components to be versioned this way too for the time being. The actual updates system will rely less on implied semver semantics and will instead be more explicit, probably on ranges of versions.

@iliana iliana requested review from smklein and leftwo November 28, 2023 18:08
@smklein smklein requested a review from davepacheco November 28, 2023 18:22
Copy link
Contributor

@leftwo leftwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why that Oximeter test failed. It does not seem related but we should
probably try to understand why it failed.

@bnaecker
Copy link
Collaborator

I've looked at the failure a bit. The test uses tokio's time facilities to pause and advance time, and then checks that an expected number of events has occurred. I've generally found the time-manipulation functions to be robust, so long as the duration one uses in tokio::time::advance is much smaller than the duration of the other timers or intervals under test. The tick resolution is 1/10th the interval of the various timers, which apparently isn't small enough. I can't get this exact situation to repro on my machine, but I definitely can if I increase the interval.

I'll make a small PR increasing the tick resolution in the call to tokio::time::advance().

bnaecker added a commit that referenced this pull request Nov 29, 2023
Reduces the tick interval in calls to `tokio::time::advance()` to ensure
all timers complete reliably. See #4566 for context.
bnaecker added a commit that referenced this pull request Nov 29, 2023
Reduces the tick interval in calls to `tokio::time::advance()` to ensure
all timers complete reliably. See #4566 for context.
@iliana iliana merged commit d525dee into main Dec 5, 2023
20 checks passed
@iliana iliana deleted the iliana/five branch December 5, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants