Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate if non-semver system versions are fine #4400

Closed
iliana opened this issue Oct 31, 2023 · 5 comments
Closed

investigate if non-semver system versions are fine #4400

iliana opened this issue Oct 31, 2023 · 5 comments
Assignees

Comments

@iliana
Copy link
Contributor

iliana commented Oct 31, 2023

Requested by @askfongjojo in the huddle this morning.

Ideally the next system version would be named "v4". We set a system version in the package job:

COMMIT=$(git rev-parse HEAD)
VERSION="1.0.3-0.ci+git${COMMIT:0:11}"
echo "$VERSION" >/work/version.txt

This is currently a semver. Need to validate whether this is treated as an opaque string or is actually parsed as semver and compared in current software.

@iliana iliana self-assigned this Oct 31, 2023
@iliana
Copy link
Contributor Author

iliana commented Oct 31, 2023

There is also a larger release engineering question of how to differentiate between pre-release artifacts that are generated from some arbitrary commit, and what the actual resulting version is. Ideally this would happen during artifact signing.

If we determine it is too difficult to move to an integer version in the repo itself, we can move to e.g. 4.0.0-whatever.

@askfongjojo
Copy link

@iliana: Thank you for filing this ticket to track the version question/investigation!

@askfongjojo
Copy link

Hey @iliana, it looks like we may be close to having a version 4 going out. It'll be great if we can bump the version string to a higher number today (4.0.0-whatever can work too! We just need it to be different from 1.0.3 - the one already deployed to customer racks). Thanks!

@iliana
Copy link
Contributor Author

iliana commented Nov 4, 2023

system_version is declared across wicket, tufaceous-lib, and nexus as a SemverVersion. I think it is safe to say that we will need to keep it a semver for now; let's do 4.0.0 plus the current CI commit suffix we're using.

This does give us the opportunity to do point releases in the future if we decide we need to (as long as they comply with semver, lol).

@iliana
Copy link
Contributor Author

iliana commented Nov 4, 2023

Cross-referencing #4437; the investigation this issue calls for is complete.

@iliana iliana closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants