-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate if non-semver system versions are fine #4400
Comments
There is also a larger release engineering question of how to differentiate between pre-release artifacts that are generated from some arbitrary commit, and what the actual resulting version is. Ideally this would happen during artifact signing. If we determine it is too difficult to move to an integer version in the repo itself, we can move to e.g. |
@iliana: Thank you for filing this ticket to track the version question/investigation! |
Hey @iliana, it looks like we may be close to having a version 4 going out. It'll be great if we can bump the version string to a higher number today ( |
This does give us the opportunity to do point releases in the future if we decide we need to (as long as they comply with semver, lol). |
Cross-referencing #4437; the investigation this issue calls for is complete. |
Requested by @askfongjojo in the huddle this morning.
Ideally the next system version would be named "v4". We set a system version in the package job:
omicron/.github/buildomat/jobs/package.sh
Lines 39 to 41 in 73c3571
This is currently a semver. Need to validate whether this is treated as an opaque string or is actually parsed as semver and compared in current software.
The text was updated successfully, but these errors were encountered: