Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 move colors to ColorConstants file #4289

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Dec 12, 2024

Moves color constants into one file and adds gray shades.

@owidbot
Copy link
Contributor

owidbot commented Dec 12, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-move-color-constants-viz

SVG tester:

Number of differences (default views): 1690 (5a3e8e) ❌
Number of differences (all views): 1015 (1ae1f1) ❌

Edited: 2024-12-13 13:51:59 UTC
Execution time: 1.28 seconds

Copy link
Member Author

sophiamersmann commented Dec 13, 2024

Merge activity

  • Dec 13, 8:54 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 13, 8:59 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 13, 9:00 AM EST: A user merged this pull request with Graphite.

@sophiamersmann sophiamersmann changed the base branch from improve-facet-legends to graphite-base/4289 December 13, 2024 13:55
@sophiamersmann sophiamersmann changed the base branch from graphite-base/4289 to master December 13, 2024 13:57
@sophiamersmann sophiamersmann force-pushed the move-color-constants-viz branch from f8488d4 to 017acac Compare December 13, 2024 13:58
@sophiamersmann sophiamersmann merged commit 09bc3c0 into master Dec 13, 2024
13 of 15 checks passed
@sophiamersmann sophiamersmann deleted the move-color-constants-viz branch December 13, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants