-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 refactor hover states / TAS-738 #4266
Conversation
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 1420 (d948c2) ❌ Edited: 2024-12-13 13:46:05 UTC |
8fec598
to
84d8063
Compare
b0bb266
to
07a0340
Compare
84d8063
to
01d39a4
Compare
07a0340
to
85b90e1
Compare
01d39a4
to
06441bd
Compare
85b90e1
to
5330b1d
Compare
06441bd
to
de825ee
Compare
5330b1d
to
2ac0267
Compare
de825ee
to
23e1af8
Compare
2ac0267
to
155d6cf
Compare
23e1af8
to
67bc52b
Compare
155d6cf
to
b4fea30
Compare
b4fea30
to
42513be
Compare
9310934
to
d5a9860
Compare
42513be
to
89a8698
Compare
d5a9860
to
4f1a062
Compare
89a8698
to
9a27a49
Compare
9a27a49
to
01cf272
Compare
4f1a062
to
db3e296
Compare
a643f80
to
a48699c
Compare
2250f24
to
7ef892f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice refactoring!
Normally, I like to represent these things in such a way that it is impossible to represent invalid state (i.e., in this case {active: true, background: true}
). but in this case, I can very much see the added benefit of using this syntax, so that's all good with me.
7ef892f
to
7f8c768
Compare
Refactor in preparation of adding focus state to line and slope charts.
Summary
InteractionState
whereactive
means 'actively focused/hovered' andbackground
means 'another element is actively focused/hovered'hover.active
is less verbose thanhover === InteractionState.active
)