Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ improve hover state of facet legends #4285

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Dec 11, 2024

Two very minor (categorical) facet legend improvements:

  • If a facet legend is hovered, then non-hovered bins are muted by reducing their opacity
  • If a facet legend bin is hovered that is not plotted by a particular facet, then all lines in that facets are muted
    • for example, hover 'Japan' in this chart: live / staging

@sophiamersmann sophiamersmann changed the title ✨ add hover state for facet legends ✨ improve hover state of facet legends Dec 11, 2024
@owidbot
Copy link
Contributor

owidbot commented Dec 11, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-improve-facet-legends

SVG tester:

Number of differences (default views): 1690 (dcfacb) ❌
Number of differences (all views): 1015 (dc1cee) ❌

Edited: 2024-12-13 13:50:29 UTC
Execution time: 1.30 seconds

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member Author

sophiamersmann commented Dec 13, 2024

Merge activity

  • Dec 13, 8:54 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 13, 8:56 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 13, 8:57 AM EST: A user merged this pull request with Graphite.

@sophiamersmann sophiamersmann changed the base branch from refactor-hover-viz to graphite-base/4285 December 13, 2024 13:54
@sophiamersmann sophiamersmann changed the base branch from graphite-base/4285 to master December 13, 2024 13:55
@sophiamersmann sophiamersmann merged commit 4038fc6 into master Dec 13, 2024
13 of 15 checks passed
@sophiamersmann sophiamersmann deleted the improve-facet-legends branch December 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants