-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ improve hover state of facet legends #4285
Merged
Merged
+73
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2024
sophiamersmann
changed the title
✨ add hover state for facet legends
✨ improve hover state of facet legends
Dec 11, 2024
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 1690 (dcfacb) ❌ Edited: 2024-12-13 13:50:29 UTC |
sophiamersmann
force-pushed
the
improve-facet-legends
branch
from
December 11, 2024 18:19
96d13d7
to
9347c5e
Compare
sophiamersmann
force-pushed
the
refactor-hover-viz
branch
from
December 12, 2024 08:40
a48699c
to
729c095
Compare
sophiamersmann
force-pushed
the
improve-facet-legends
branch
from
December 12, 2024 08:40
9347c5e
to
3a55b03
Compare
sophiamersmann
force-pushed
the
refactor-hover-viz
branch
from
December 12, 2024 09:15
729c095
to
2ef6c8e
Compare
sophiamersmann
force-pushed
the
improve-facet-legends
branch
from
December 12, 2024 09:15
3a55b03
to
2bebfea
Compare
sophiamersmann
force-pushed
the
refactor-hover-viz
branch
from
December 12, 2024 09:40
2ef6c8e
to
2250f24
Compare
sophiamersmann
force-pushed
the
improve-facet-legends
branch
from
December 12, 2024 09:40
2bebfea
to
689aa58
Compare
sophiamersmann
force-pushed
the
refactor-hover-viz
branch
from
December 12, 2024 10:51
2250f24
to
7ef892f
Compare
sophiamersmann
force-pushed
the
improve-facet-legends
branch
from
December 12, 2024 10:51
689aa58
to
ce3a584
Compare
This was referenced Dec 12, 2024
marcelgerber
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
This was referenced Dec 12, 2024
sophiamersmann
force-pushed
the
refactor-hover-viz
branch
from
December 13, 2024 13:19
7ef892f
to
7f8c768
Compare
sophiamersmann
force-pushed
the
improve-facet-legends
branch
from
December 13, 2024 13:19
ce3a584
to
f0dcf95
Compare
sophiamersmann
changed the base branch from
refactor-hover-viz
to
graphite-base/4285
December 13, 2024 13:54
sophiamersmann
force-pushed
the
improve-facet-legends
branch
from
December 13, 2024 13:55
f0dcf95
to
d9b66c9
Compare
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two very minor (categorical) facet legend improvements: