Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐝 (schema) set missing defaults #3743

Closed
wants to merge 2 commits into from

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jun 25, 2024

Summary

I went through the current config schema and tried to find all fields where a default value is missing. In the end, I updated the following defaults:

  • Sets true as default for hideRelativeToggle
  • Sets 2 as default for dimensions[*].display.numDecimalPlaces
  • Sets 3 as default for dimensions[*].display.numSignificantFigures
  • Sets 2020-01-21 as default for dimensions[*].display.zeroDay

Copy link
Member Author

sophiamersmann commented Jun 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

@sophiamersmann sophiamersmann changed the title 🐝 (schema) set default for hideRelativeToggle 🐝 (grapher) config schema touchups Jun 25, 2024
@owidbot
Copy link
Contributor

owidbot commented Jun 25, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-grapher-schema-updates

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-06-25 15:49:13 UTC
Execution time: 1.22 seconds

@sophiamersmann sophiamersmann force-pushed the grapher-schema-updates branch from 73516c1 to b63a8c0 Compare July 8, 2024 14:22
@sophiamersmann sophiamersmann changed the base branch from master to db-chart-configs July 8, 2024 14:22
@sophiamersmann sophiamersmann changed the title 🐝 (grapher) config schema touchups 🐝 (schema) set missing defaults Jul 8, 2024
@sophiamersmann sophiamersmann force-pushed the db-chart-configs branch 6 times, most recently from 7673208 to be4487e Compare July 15, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants