-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐝 (schema) set missing defaults #3743
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite |
sophiamersmann
changed the title
🐝 (schema) set default for hideRelativeToggle
🐝 (grapher) config schema touchups
Jun 25, 2024
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-06-25 15:49:13 UTC |
sophiamersmann
force-pushed
the
grapher-schema-updates
branch
from
July 8, 2024 14:22
73516c1
to
b63a8c0
Compare
This was referenced Jul 8, 2024
sophiamersmann
changed the title
🐝 (grapher) config schema touchups
🐝 (schema) set missing defaults
Jul 8, 2024
2 tasks
sophiamersmann
force-pushed
the
db-chart-configs
branch
6 times, most recently
from
July 15, 2024 13:53
7673208
to
be4487e
Compare
3 tasks
This was referenced Jul 31, 2024
This was referenced Aug 13, 2024
This was referenced Aug 19, 2024
This was referenced Aug 20, 2024
This was referenced Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I went through the current config schema and tried to find all fields where a default value is missing. In the end, I updated the following defaults:
true
as default forhideRelativeToggle
2
as default fordimensions[*].display.numDecimalPlaces
3
as default fordimensions[*].display.numSignificantFigures
2020-01-21
as default fordimensions[*].display.zeroDay