Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 remove direct R2 bindings #3856

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Aug 6, 2024

This PR is abandoned and will not be merged

🚧 remove direct R2 bindings

🚧 work on fetching from R2

🚧 attempt to use s3client sdk

🚧 s3client doesn't work inside worker, removing it

Copy link
Contributor Author

danyx23 commented Aug 6, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danyx23 and the rest of your teammates on Graphite Graphite

@owidbot
Copy link
Contributor

owidbot commented Aug 6, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-interface-with-r2-via-s3-api

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-06 18:43:39 UTC
Execution time: 1.17 seconds

@danyx23 danyx23 force-pushed the use-r2-grapher-configs-in-cf-functions branch from 6e9dc2f to 7c43c3d Compare August 7, 2024 08:10
@danyx23 danyx23 force-pushed the interface-with-r2-via-s3-api branch from 4bedc2e to 86a8706 Compare August 7, 2024 08:10
@danyx23 danyx23 force-pushed the use-r2-grapher-configs-in-cf-functions branch from 7c43c3d to ae06e0b Compare August 7, 2024 09:47
@danyx23 danyx23 force-pushed the interface-with-r2-via-s3-api branch from 86a8706 to a4a4aea Compare August 7, 2024 09:47
@danyx23 danyx23 force-pushed the use-r2-grapher-configs-in-cf-functions branch from ae06e0b to b761e5c Compare August 7, 2024 20:36
@danyx23 danyx23 force-pushed the interface-with-r2-via-s3-api branch from a4a4aea to fd2e830 Compare August 7, 2024 20:36
@danyx23 danyx23 force-pushed the use-r2-grapher-configs-in-cf-functions branch from b761e5c to fb46101 Compare August 8, 2024 09:39
@danyx23 danyx23 force-pushed the interface-with-r2-via-s3-api branch from fd2e830 to 54c6f8d Compare August 8, 2024 09:39
@danyx23 danyx23 force-pushed the use-r2-grapher-configs-in-cf-functions branch from fb46101 to d1a51d9 Compare August 8, 2024 11:06
@danyx23 danyx23 force-pushed the interface-with-r2-via-s3-api branch from 54c6f8d to c684c2f Compare August 8, 2024 11:06
@danyx23 danyx23 force-pushed the use-r2-grapher-configs-in-cf-functions branch from d1a51d9 to 6478da8 Compare August 8, 2024 11:41
@danyx23 danyx23 force-pushed the interface-with-r2-via-s3-api branch from c684c2f to ddabd51 Compare August 8, 2024 11:41
@danyx23 danyx23 force-pushed the use-r2-grapher-configs-in-cf-functions branch from 6478da8 to 76d65b2 Compare August 8, 2024 14:23
@danyx23 danyx23 force-pushed the interface-with-r2-via-s3-api branch from ddabd51 to 4370382 Compare August 8, 2024 14:23
@danyx23 danyx23 force-pushed the use-r2-grapher-configs-in-cf-functions branch 5 times, most recently from f8b200f to 87f0855 Compare August 13, 2024 13:47
@danyx23 danyx23 force-pushed the use-r2-grapher-configs-in-cf-functions branch from 87f0855 to eb7b9d2 Compare August 13, 2024 16:49
@danyx23 danyx23 closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants