-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdd: fetch variable-level config by uuid #3922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelgerber
changed the base branch from
master
to
fetch-grapher-config-by-uuid
September 3, 2024 17:05
marcelgerber
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 3, 2024 17:06
23ece94
to
e287f6e
Compare
sophiamersmann
force-pushed
the
fetch-grapher-config-by-uuid
branch
6 times, most recently
from
September 5, 2024 07:42
6bc713d
to
1aae0c6
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
3 times, most recently
from
September 5, 2024 12:31
41c76dc
to
0b7eadc
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 5, 2024 13:38
e287f6e
to
78b4f8f
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @marcelgerber and the rest of your teammates on Graphite |
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 5, 2024 18:37
0b7eadc
to
39b26de
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 5, 2024 18:37
bcbe4b0
to
e4efab7
Compare
danyx23
changed the base branch from
fetch-grapher-config-by-uuid
to
multiembedder-use-config-api
September 5, 2024 18:37
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 9, 2024 09:33
b5de606
to
0be9de1
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 9, 2024 09:33
e4efab7
to
f1605f2
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 9, 2024 11:53
0be9de1
to
e5338b6
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 9, 2024 11:53
f1605f2
to
0d28fa6
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 9, 2024 14:46
e5338b6
to
8f4418c
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 9, 2024 14:49
0d28fa6
to
4afe1f2
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 07:59
8f4418c
to
6ea8ff0
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 07:59
4afe1f2
to
daa6ad1
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 08:06
6ea8ff0
to
14065aa
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 08:06
daa6ad1
to
f8ceca9
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 09:56
14065aa
to
25404f1
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 09:56
f8ceca9
to
2281582
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 10:24
25404f1
to
53ab64b
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 10:24
2281582
to
30649a6
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 10:35
53ab64b
to
35deed4
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 10:35
30649a6
to
e29c5b9
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 10:56
35deed4
to
4c94b5a
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 10:58
e29c5b9
to
2eb9f96
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 11:16
4c94b5a
to
18dd056
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 11:18
2eb9f96
to
9e56a9a
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
from
September 10, 2024 11:31
18dd056
to
868a5f7
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 11:33
9e56a9a
to
577235d
Compare
danyx23
force-pushed
the
multiembedder-use-config-api
branch
2 times, most recently
from
September 10, 2024 11:48
caecd68
to
d728828
Compare
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 11:49
577235d
to
e770dda
Compare
danyx23
changed the base branch from
multiembedder-use-config-api
to
graphite-base/3922
September 10, 2024 12:01
danyx23
force-pushed
the
mdd-fetch-config-by-uuid
branch
from
September 10, 2024 12:02
e770dda
to
402738f
Compare
This was referenced Sep 11, 2024
8 tasks
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently quite painful to test -- sorry!
During the bake, a
variableIdToGrapherConfigMap
is written into the HTML.It maps primary variable IDs to their respective
grapherConfigIdAdmin ?? grapherConfigIdETL ?? null
.If such a UUID is present, then the config is fetched at runtime.
It is currently a bit hard to make grapher wait for this grapher config to arrive - it displays an empty screen during the loading, rather than a loading indicator of some sort.
We can tweak this later on, but we don't want grapher to render before the config override has been fetched, otherwise we're flash-rendering twice with different FAUST.