Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdd: fetch variable-level config by uuid #3922

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Sep 3, 2024

This is currently quite painful to test -- sorry!

During the bake, a variableIdToGrapherConfigMap is written into the HTML.
It maps primary variable IDs to their respective grapherConfigIdAdmin ?? grapherConfigIdETL ?? null.

If such a UUID is present, then the config is fetched at runtime.
It is currently a bit hard to make grapher wait for this grapher config to arrive - it displays an empty screen during the loading, rather than a loading indicator of some sort.
We can tweak this later on, but we don't want grapher to render before the config override has been fetched, otherwise we're flash-rendering twice with different FAUST.

@marcelgerber marcelgerber changed the base branch from master to fetch-grapher-config-by-uuid September 3, 2024 17:05
@marcelgerber marcelgerber force-pushed the mdd-fetch-config-by-uuid branch from 23ece94 to e287f6e Compare September 3, 2024 17:06
@marcelgerber marcelgerber requested a review from danyx23 September 3, 2024 17:06
@sophiamersmann sophiamersmann force-pushed the fetch-grapher-config-by-uuid branch 6 times, most recently from 6bc713d to 1aae0c6 Compare September 5, 2024 07:42
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch 3 times, most recently from 41c76dc to 0b7eadc Compare September 5, 2024 12:31
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from e287f6e to 78b4f8f Compare September 5, 2024 13:38
@danyx23 danyx23 force-pushed the fetch-grapher-config-by-uuid branch from 0b7eadc to 39b26de Compare September 5, 2024 18:37
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from bcbe4b0 to e4efab7 Compare September 5, 2024 18:37
@danyx23 danyx23 changed the base branch from fetch-grapher-config-by-uuid to multiembedder-use-config-api September 5, 2024 18:37
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from b5de606 to 0be9de1 Compare September 9, 2024 09:33
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from e4efab7 to f1605f2 Compare September 9, 2024 09:33
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 0be9de1 to e5338b6 Compare September 9, 2024 11:53
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from f1605f2 to 0d28fa6 Compare September 9, 2024 11:53
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from e5338b6 to 8f4418c Compare September 9, 2024 14:46
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from 0d28fa6 to 4afe1f2 Compare September 9, 2024 14:49
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 8f4418c to 6ea8ff0 Compare September 10, 2024 07:59
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from 4afe1f2 to daa6ad1 Compare September 10, 2024 07:59
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 6ea8ff0 to 14065aa Compare September 10, 2024 08:06
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from daa6ad1 to f8ceca9 Compare September 10, 2024 08:06
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 14065aa to 25404f1 Compare September 10, 2024 09:56
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from f8ceca9 to 2281582 Compare September 10, 2024 09:56
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 25404f1 to 53ab64b Compare September 10, 2024 10:24
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from 2281582 to 30649a6 Compare September 10, 2024 10:24
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 53ab64b to 35deed4 Compare September 10, 2024 10:35
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from 30649a6 to e29c5b9 Compare September 10, 2024 10:35
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 35deed4 to 4c94b5a Compare September 10, 2024 10:56
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from e29c5b9 to 2eb9f96 Compare September 10, 2024 10:58
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 4c94b5a to 18dd056 Compare September 10, 2024 11:16
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from 2eb9f96 to 9e56a9a Compare September 10, 2024 11:18
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch from 18dd056 to 868a5f7 Compare September 10, 2024 11:31
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from 9e56a9a to 577235d Compare September 10, 2024 11:33
@danyx23 danyx23 force-pushed the multiembedder-use-config-api branch 2 times, most recently from caecd68 to d728828 Compare September 10, 2024 11:48
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from 577235d to e770dda Compare September 10, 2024 11:49
@danyx23 danyx23 changed the base branch from multiembedder-use-config-api to graphite-base/3922 September 10, 2024 12:01
@danyx23 danyx23 force-pushed the mdd-fetch-config-by-uuid branch from e770dda to 402738f Compare September 10, 2024 12:02
@danyx23 danyx23 changed the base branch from graphite-base/3922 to master September 10, 2024 12:03
Copy link
Contributor

danyx23 commented Sep 10, 2024

Merge activity

  • Sep 10, 10:04 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Sep 10, 10:04 AM EDT: @danyx23 merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants