🔨 (static charts) use a shared set of font sizes #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2024
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
sophiamersmann
changed the title
sophiamersmann
force-pushed
the
export-charts-for-mobile
branch
from
4802648 to
f59fec2
Compare
sophiamersmann
force-pushed
the
refactor-grapher-font-size
branch
from
c8baa93 to
e762c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor, no behaviour change.
Use a shared set of font sizes, getting rid of magic values.
The SVG tester complains about all slope charts because their labels are slightly bigger now (used to be 10.4px, now 10.5px).