🎉 (static charts) add portrait mode to Grapher's download options

[sophiamersmann]

Adds portrait mode to Grapher's download options. Only available to download for authors, not for users.

• Grapher currently exports charts at a fixed size (in landscape format)
• This PR adds support for one more format (called “portrait” for now)
  • We might want to add more presets in the future (for example, for Instagram) but that’s tbd
• The additional format should be available for download from the chart itself

This turned into a mild refactor of how the thumbnail worker calls Grapher and how Grapher internally handles font size:

• Removes isGeneratingThumbnail – requiring an external caller to identify themselves is an anti-pattern
  • Thumbnail-specific behaviour only concerned the font size
  • The font size code has been refactored such that the isGeneratingThumbnail flag is unnecessary
• Also fixes a thumbnail bug where details on the bottom overflowed (live / staging)

Other changes:

• Adds a keyboard shortcut for toggling the download modal for convenience ("d")
• Cleans up code around showAdminControls and code in the DownloadModal
• Renames isExportingtoSvgOrPng to isExportingToSvgOrPng

Future work:

• Unpleasant UX when Grapher prepares a static export for download #2969

[sophiamersmann]

Current dependencies on/for this PR:

• master
  • PR 🎉 (static charts) add portrait mode to Grapher's download options #2967 👈
    • PR 🎉 (static charts) add Export tab to the chart admin #2975
      • PR ✨ (static charts) make charts mobile-friendly #2977
        • PR 🔨 (static charts) use a shared set of font sizes #3079

This stack of pull requests is managed by Graphite.

[sophiamersmann]

I'm doing a simple swap for now, but will look into what's a sensible default in subsequent PRs

[ikesau]

Code looks good! tested on safari, chrome, and firefox.

[github-actions]

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

[sophiamersmann]

Merge activity

• Jan 9, 10:17 AM: @sophiamersmann started a stack merge that includes this pull request via Graphite.
• Jan 9, 10:18 AM: @sophiamersmann merged this pull request with Graphite.