-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (static charts) make charts mobile-friendly #2977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
sophiamersmann
force-pushed
the
export-charts-for-mobile
branch
from
December 1, 2023 17:13
32a86a1
to
16f75c8
Compare
sophiamersmann
force-pushed
the
add-export-tab-in-admin
branch
from
December 4, 2023 09:05
f680c74
to
c1c793b
Compare
sophiamersmann
force-pushed
the
export-charts-for-mobile
branch
from
December 4, 2023 09:05
16f75c8
to
ec64f36
Compare
sophiamersmann
force-pushed
the
add-export-tab-in-admin
branch
from
December 11, 2023 18:29
c1c793b
to
5df7ecb
Compare
sophiamersmann
force-pushed
the
export-charts-for-mobile
branch
11 times, most recently
from
December 15, 2023 10:44
d929dad
to
c24739c
Compare
sophiamersmann
force-pushed
the
add-export-tab-in-admin
branch
from
December 15, 2023 17:31
29f3827
to
20a7a6b
Compare
sophiamersmann
force-pushed
the
export-charts-for-mobile
branch
from
December 15, 2023 17:31
c5152ba
to
53dc839
Compare
sophiamersmann
force-pushed
the
add-export-tab-in-admin
branch
from
December 19, 2023 16:11
20a7a6b
to
b829855
Compare
sophiamersmann
force-pushed
the
export-charts-for-mobile
branch
from
December 19, 2023 16:11
0a310a8
to
02c6628
Compare
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
sophiamersmann
force-pushed
the
add-export-tab-in-admin
branch
from
January 8, 2024 11:16
b829855
to
6141ebc
Compare
sophiamersmann
force-pushed
the
export-charts-for-mobile
branch
from
January 9, 2024 15:20
4802648
to
f59fec2
Compare
It's a little unhinged, but why not 😅 export const GRAPHER_FONT_SCALE_9_6 = 9.6 / BASE_FONT_SIZE
export const GRAPHER_FONT_SCALE_10 = 10 / BASE_FONT_SIZE
export const GRAPHER_FONT_SCALE_10_5 = 10.5 / BASE_FONT_SIZE
export const GRAPHER_FONT_SCALE_11 = 11 / BASE_FONT_SIZE
export const GRAPHER_FONT_SCALE_11_2 = 11.2 / BASE_FONT_SIZE
export const GRAPHER_FONT_SCALE_12 = 12 / BASE_FONT_SIZE
export const GRAPHER_FONT_SCALE_12_8 = 12.8 / BASE_FONT_SIZE
export const GRAPHER_FONT_SCALE_13 = 13 / BASE_FONT_SIZE
export const GRAPHER_FONT_SCALE_14 = 14 / BASE_FONT_SIZE Merged in the next PR! |
Nice, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of small improvements to make static charts more mobile-friendly. Some changes apply to static+mobile charts only, others apply to all charts (interactive and static).
For all charts:
baseFontSize
to scale all font sizes upbaseFontSize
= 16px)For static+mobile charts only: