🐛 (chart-admin) only show DoD toggle if the chart has details

owid · Dec 15, 2023 · 29f3827 · 29f3827
1 parent a97ee71
commit 29f3827
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/adminSiteClient/EditorExportTab.tsx b/adminSiteClient/EditorExportTab.tsx
@@ -29,6 +29,7 @@ type OriginalGrapher = Pick<
     | "note"
     | "originUrl"
     | "shouldIncludeDetailsInStaticExport"
+    | "detailsOrderedByReference"
 >
 
 type ExportSettingsByChartId = Record<number, ExportSettings>
@@ -133,6 +134,7 @@ export class EditorExportTab extends React.Component<EditorExportTabProps> {
             originUrl: this.grapher.originUrl,
             shouldIncludeDetailsInStaticExport:
                 this.grapher.shouldIncludeDetailsInStaticExport,
+            detailsOrderedByReference: this.grapher.detailsOrderedByReference,
         }
     }
 
@@ -286,14 +288,19 @@ export class EditorExportTab extends React.Component<EditorExportTabProps> {
                             }
                         />
                     )}
-                    <Toggle
-                        label="Details on demand"
-                        value={this.settings.shouldIncludeDetailsInStaticExport}
-                        onValue={(value) =>
-                            (this.settings.shouldIncludeDetailsInStaticExport =
-                                value)
-                        }
-                    />
+                    {this.originalGrapher.detailsOrderedByReference.size >
+                        0 && (
+                        <Toggle
+                            label="Details on demand"
+                            value={
+                                this.settings.shouldIncludeDetailsInStaticExport
+                            }
+                            onValue={(value) =>
+                                (this.settings.shouldIncludeDetailsInStaticExport =
+                                    value)
+                            }
+                        />
+                    )}
                 </Section>
                 <Section name="Export static chart">
                     <div className="DownloadButtons">