Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site torch dataset #74

Merged
merged 26 commits into from
Nov 5, 2024
Merged

site torch dataset #74

merged 26 commits into from
Nov 5, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 25, 2024

Pull Request

Description

First try at adding "Site" workflow

Things to do

  • change to use site_id not system_id
  • Add in site dropout

#73

How Has This Been Tested?

  • added a new test
  • old tests
  • test out with wind RUVNL data
from ocf_data_sampler.torch_datasets.site import SitesDataset
site_pipeline = SitesDataset(config_filename='test_config.yaml')
batch = site_pipeline.__getitem__(0)
print(batch)

with the following config

general:
  description: Test config for site PVNet
  name: site_pvnet_test

input_data:

  site:
    filename: "/mnt/storage_ssd_4tb/india_wind_data.nc"
    metadata_filename:  "/mnt/storage_ssd_4tb/india_wind_metadata2.csv"
    time_resolution_minutes: 60
    history_minutes: 60
    forecast_minutes: 120
  nwp:
    ecmwf:
      nwp_provider: ecmwf
      nwp_zarr_path: "/mnt/storage_b/ecmwf_india_ad_crop/*.zarr"
      history_minutes: 60
      forecast_minutes: 120
      time_resolution_minutes: 60
      nwp_channels:
        - t2m # 2-metre temperature
      nwp_image_size_pixels_height: 2
      nwp_image_size_pixels_width: 2
      dropout_timedeltas_minutes: [-180]
      dropout_fraction: 1.0

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as draft October 25, 2024 10:16
@peterdudfield peterdudfield changed the title first try at site workflow site torch dataset Oct 28, 2024
@peterdudfield peterdudfield marked this pull request as ready for review October 28, 2024 17:54
scripts/refactor_site.py Outdated Show resolved Hide resolved
@peterdudfield
Copy link
Contributor Author

Thanks for you comments @AUdaltsova and @Sukh-P

Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant work adding this in!

Copy link
Contributor

@AUdaltsova AUdaltsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this! Looks so good!

@peterdudfield peterdudfield merged commit 25a9441 into main Nov 5, 2024
3 checks passed
@peterdudfield peterdudfield deleted the issue/site-pipeline branch November 5, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants