Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site torch dataset #74
site torch dataset #74
Changes from 24 commits
2a4acfc
941cf03
acdad11
658f0fd
9ad0975
5ba4cd8
0964a48
e4882d5
021cf41
df7b13a
3a85983
ae80011
972bb0f
f930ff5
7d00ab5
7dc2432
e75f7ad
e7a7a22
3a666c4
b59aee2
1d9317c
f9d49d3
8660732
61f697b
7c03a81
158fee1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think checking for
in_config.gsp
is enough.zarr_path
is a required field so config model should be checking it exists for youThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, ok, need to look into this. There's defiantely a test that makes sure it works with no gsp data. Ill have a further look at this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, there is a funny edge case, where in live we have no live GSP data, as it's not used for the forecast. But we still need
gsp.time_resolution_minutes
,gsp_config.forecast_minutes
andgsp_config.history_minutes
for the sun coords position. There's a slight case for making a Sun configuration but, perhaps its better in a different PR