New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dataset_dict #75

Open

peterdudfield opened this issue Oct 25, 2024 · 1 comment

Contributor

peterdudfield commented Oct 25, 2024

Detailed Description

Currently we use a dict to hold our datasets. This potentially is a bit risky and we might get the keys wrong.

Context

good to move away from dictionarys
could be liked to Create batch class #71
currently here and various other places

Possible Implementation

could make a class

peterdudfield mentioned this issue

site torch dataset #74

Merged

10 tasks

Contributor Author

peterdudfield commented Nov 5, 2024

merge_dicts could also be changed, see comments in #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment