Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ir: Start metrics and control service before blockchain init #2679

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

carpawell
Copy link
Member

@carpawell carpawell commented Dec 14, 2023

Sync may take some time while nothing stops IR from showing some useful info.

Closes #2585.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (34cdb12) 28.49% compared to head (3686ca7) 30.08%.

❗ Current head 3686ca7 differs from pull request most recent head c33a21a. Consider uploading reports for the commit c33a21a to get more accurate results

Files Patch % Lines
pkg/innerring/innerring.go 0.00% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
+ Coverage   28.49%   30.08%   +1.59%     
==========================================
  Files         413      406       -7     
  Lines       31961    30187    -1774     
==========================================
- Hits         9108     9083      -25     
+ Misses      22073    20324    -1749     
  Partials      780      780              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/innerring/innerring.go Outdated Show resolved Hide resolved
@carpawell carpawell force-pushed the fix/missing-metrics-on-startup branch from beee2c3 to 3686ca7 Compare December 15, 2023 12:48
@roman-khimov
Copy link
Member

Conflicts.

Sync may take some time while nothing stops IR from showing some useful info.
Closes #2677.

Signed-off-by: Pavel Karpy <[email protected]>
@carpawell carpawell force-pushed the fix/missing-metrics-on-startup branch from 3686ca7 to c33a21a Compare December 18, 2023 14:24
@carpawell
Copy link
Member Author

No conflicts.

@roman-khimov roman-khimov merged commit c1b8cac into master Dec 18, 2023
7 of 8 checks passed
@roman-khimov roman-khimov deleted the fix/missing-metrics-on-startup branch December 18, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

control port must be opened and handled on start
3 participants