Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control port must be opened and handled on start #2585

Closed
532910 opened this issue Sep 18, 2023 · 5 comments · Fixed by #2645 or #2679
Closed

control port must be opened and handled on start #2585

532910 opened this issue Sep 18, 2023 · 5 comments · Fixed by #2645 or #2679
Assignees
@carpawell
Labels
enhancement Improving existing functionality good first issue Good for newcomers
Milestone
v0.39.1

Comments

@532910
Copy link

532910 commented Sep 18, 2023

The same as #2428 but for control port.
@532910 532910 added the triage label Sep 18, 2023
@roman-khimov roman-khimov added enhancement Improving existing functionality good first issue Good for newcomers and removed triage labels Sep 18, 2023
@roman-khimov roman-khimov added this to the v0.39.0 milestone Sep 18, 2023
@532910
Copy link
Author

532910 commented Sep 19, 2023

moreover, program must not start in case of control port opening failure

@carpawell
Copy link
Member

Do we want to provide a separate control status for every operation (e.g. "starting service X") instead of generic "starting", "ready"?

@cthulhu-rider, @roman-khimov

@roman-khimov
Copy link
Member

Yes. We have very distinct states especially wrt integrated CN.

AliceInHunterland added a commit that referenced this issue Nov 14, 2023
@AliceInHunterland
conrtol: set the highest priority for control service.
63c35c4 
Control ports should be initialised and start served first of all.

Closes: #2585.

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland mentioned this issue Nov 14, 2023
Merged
AliceInHunterland added a commit that referenced this issue Nov 14, 2023
@AliceInHunterland
conrtol: set the highest priority for control service.
d962250 
Control ports should be initialised and start served first of all.

Closes: #2585.

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland mentioned this issue Nov 14, 2023
Open
@carpawell carpawell mentioned this issue Nov 16, 2023
Open
AliceInHunterland added a commit that referenced this issue Nov 16, 2023
@AliceInHunterland
control: set the highest priority for control service.
b9c1a5b 
Control ports should be initialised and start served first of all. As
initControlService already listening endpoint, no need of preRun of
control service.

Closes: #2585.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 16, 2023
@AliceInHunterland
control: set the highest priority for control service.
e9c7422 
Control ports should be initialised and start served first of all. As
initControlService already listening endpoint, no need of preRun of
control service in storage nodes.

Closes: #2585.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 17, 2023
@AliceInHunterland
control: set the highest priority for control service.
a595390 
Control ports should be initialised and start served first of all. As
initControlService already listening endpoint, no need of preRun of
control service in storage nodes.

Closes: #2585.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Nov 20, 2023
@AliceInHunterland
control: set the highest priority for control service
5815476 
Control ports should be initialised and start served first of all. The
priority of running control service is maximized for both SN and IR.

Closes: #2585.

Signed-off-by: Ekaterina Pavlova <[email protected]>
roman-khimov added a commit that referenced this issue Nov 20, 2023
@roman-khimov
control: set the highest priority for control service. (#2645)
67c5b02 
Closes: #2585.
@carpawell carpawell mentioned this issue Nov 21, 2023
Merged
@532910 532910 reopened this Dec 15, 2023
@532910
Copy link
Author

532910 commented Dec 15, 2023

not fixed

[root@tenes6:~]# grep -A2 'control:' /etc/neofs/ir/config.yml 
control:
  grpc:
    endpoint: localhost:8090

[root@tenes6:~]# s lsof -i -s tcp:listen -P | grep neofs-ir
neofs-ir  25696        neofs-ir    7u  IPv4 1968265      0t0  TCP localhost:9902 (LISTEN)
neofs-ir  25696        neofs-ir    8u  IPv4 1968267      0t0  TCP localhost:9901 (LISTEN)
[root@tenes6:~]# s lsof -i -s tcp:listen -P | grep 8090

log:

Dec 15 07:23:21 tenes6 systemd[1]: Started NeoFS InnerRing node.
Dec 15 07:23:21 tenes6 neofs-ir[25696]: 2023-12-15T07:23:21.220Z        info        neofs-ir/main.go:128        prometheus is enabled
Dec 15 07:23:21 tenes6 neofs-ir[25696]: 2023-12-15T07:23:21.220Z        info        neofs-ir/main.go:128        pprof is enabled
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.384Z        info        innerring/innerring.go:494        auto-deployment configured, initializing Sidechain...
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.407Z        info        deploy/deploy.go:243        initializing NNS contract on the chain...
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.408Z        info        deploy/util.go:69        listening to new blocks...
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.408Z        info        deploy/nns.go:127        reading on-chain state of the NNS contract by ID=1
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.410Z        info        deploy/deploy.go:250        NNS contract successfully initialized on the chain        {"address": "78d64e150ce79fa492b0b771a834b50af3cc08fb"}
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.410Z        info        deploy/deploy.go:252        enable Notary service for the committee...
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.410Z        info        deploy/notary.go:72        committee is multi-acc, multi-signature is needed for Notary role designation
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.411Z        info        deploy/notary.go:94        checking Notary role of the committee members...
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.412Z        info        deploy/notary.go:112        all committee members have a Notary role
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.413Z        info        deploy/deploy.go:268        Notary service successfully enabled for the committee
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.413Z        info        deploy/notary.go:934        tracking Notary balance for auto-replenishment...
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.414Z        info        deploy/deploy.go:283        making initial transfer of funds to the committee...
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.414Z        info        deploy/notary.go:1059        listening to committee notary requests...
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.416Z        info        deploy/funds.go:119        got current balance of the validator multi-sig account, distributing between the committee...        {"NEO": "0", "GAS": "3696500051826760"}
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.417Z        info        deploy/funds.go:144        enough GAS on the committee member's account, skip transfer        {"member": "0b86534a9a264d28b79155b0ec36d555ed0068eb1b0c4d40c35cc7d2f04759b8e0aafbbc4826f89cc8e1f0a4ef433194026e90c769dfc157e8bb02f2d8fe532c", "balance": "24083032644257", "need at least": "15000000000"}
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.417Z        info        deploy/funds.go:144        enough GAS on the committee member's account, skip transfer        {"member": "15e735a657f6e23478728d1d0718d516bf50c06c2abd92ec7c00eba2bd7a2552d215a67ff3844e6e68cdbe074b61697665778e4161a5489b235cbb891403bd38", "balance": "18615549431817", "need at least": "15000000000"}
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.418Z        info        deploy/funds.go:144        enough GAS on the committee member's account, skip transfer        {"member": "37f5f45e5be5aeae4a919d0787fcb743656560949061d5b8b05509b85ffbfd5378c25c9361f5fea90ed818042d4da27f0afa3d38c5135654320fb56e3137f095", "balance": "18118317361510", "need at least": "15000000000"}
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.419Z        info        deploy/funds.go:144        enough GAS on the committee member's account, skip transfer        {"member": "6f9b40a73f29787ef5b289ac845bc43c64680fdd42fc170b1171d3c57213a89f30606ad2bbefbbcf6a4314cd9f1c815b89396649444a84f96cf846e1104b7490", "balance": "24140474835251", "need at least": "15000000000"}
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.420Z        info        deploy/funds.go:144        enough GAS on the committee member's account, skip transfer        {"member": "72350def90715494b857315c9b9c70181739eeec52d777424fef2891c3396cad78bdbdeb45f39cae3231995d70203e0a7cd889081dcabe52cf8bf8808e938fe4", "balance": "24060954223372", "need at least": "15000000000"}
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.420Z        info        deploy/funds.go:144        enough GAS on the committee member's account, skip transfer        {"member": "a8cee2d3877bcce5b4595578714d77ca2d47673150b8b9cd4e391b7c73b6bda3d80eebf2a7c322cff94898ac01358972be88f6bafe3c7c75b930bd9f4e9f0751", "balance": "14900734783517", "need at least": "15000000000"}
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.421Z        info        deploy/funds.go:144        enough GAS on the committee member's account, skip transfer        {"member": "c2efdc01181b0bc14fc19e0acb12281396c8c9ffe64458d621d781a1ded436b7450a4550e5c428591c27002c8c141ac60a3835ee700617595b66d0baa1a327d2", "balance": "24097718703907", "need at least": "15000000000"}
Dec 15 07:23:23 tenes6 neofs-ir[25696]: 2023-12-15T07:23:23.422Z        info        deploy/funds.go:208        need transfer from validator multi-sig account but attempts are disabled, will wait for a leader

@roman-khimov roman-khimov modified the milestones: v0.39.0, v0.40.0 Dec 15, 2023
@carpawell
Copy link
Member

Should be fixed with #2679.

@roman-khimov roman-khimov modified the milestones: v0.40.0, v0.39.1 Dec 15, 2023
@carpawell carpawell mentioned this issue Dec 18, 2023
Merged
roman-khimov added a commit that referenced this issue Dec 18, 2023
@roman-khimov
ir: Start metrics and control service before blockchain init (#2679)
c1b8cac 
Sync may take some time while nothing stops IR from showing some useful
info.

Closes #2585.
@roman-khimov roman-khimov mentioned this issue Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality good first issue Good for newcomers
Projects
None yet
Milestone
v0.39.1
4 participants
@532910 @roman-khimov @carpawell @AliceInHunterland