Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.39.0 ir version metric dropped #2677

Closed
532910 opened this issue Dec 14, 2023 · 7 comments
Closed

0.39.0 ir version metric dropped #2677

532910 opened this issue Dec 14, 2023 · 7 comments
Assignees
Labels
bug Something isn't working neofs-ir Inner Ring node application issues
Milestone

Comments

@532910
Copy link

532910 commented Dec 14, 2023

% neofs-ir --version
NeoFS Inner Ring node
Version: 0.39.0 
GoVersion: go1.21.1
% curl -s localhost:9901 | grep '^neofs_ir_version'
%
% neofs-ir --version
NeoFS Inner Ring node
Version: v0.38.1 
GoVersion: go1.20.4
% curl -s localhost:9901 | grep '^neofs_ir_version'
neofs_ir_version{version="v0.38.1"} 1
@carpawell
Copy link
Member

@532910, can you check that 9901 is the right port? Can not reproduce it.

@532910
Copy link
Author

532910 commented Dec 14, 2023

yes, the port is correct, you can check it yourself on tenes1

@roman-khimov
Copy link
Member

It's synchronizing the chain and IR is not yet really active. But yeah, it can be improved.

@roman-khimov roman-khimov added bug Something isn't working and removed triage labels Dec 14, 2023
@roman-khimov roman-khimov added this to the v0.40.0 milestone Dec 14, 2023
carpawell added a commit that referenced this issue Dec 14, 2023
Sync may take some time while nothing stops IR from showing some useful info.
Closes #2677.

Signed-off-by: Pavel Karpy <[email protected]>
@532910
Copy link
Author

532910 commented Dec 15, 2023

It's synchronizing the chain and IR is not yet really active. But yeah, it can be improved.

tenes6 and tenes7 has external cn and also doesn't provide this metric, so chain synchronizing is not related.

@carpawell
Copy link
Member

@532910, is curl -s localhost:9901 healthy? Can you ensure that we dropped the metric, meaning all the metrics are available but no version found?

carpawell added a commit that referenced this issue Dec 15, 2023
Sync may take some time while nothing stops IR from showing some useful info.
Closes #2677.

Signed-off-by: Pavel Karpy <[email protected]>
@532910
Copy link
Author

532910 commented Dec 15, 2023

sure, you can check it yourself:

[sergio@tenes7:~]% neofs-ir --version
NeoFS Inner Ring node
Version: 0.39.0 
GoVersion: go1.21.1
[sergio@tenes7:~]% curl -s localhost:9901 | grep '^go_info'
go_info{version="go1.21.1"} 1
[sergio@tenes7:~]% curl -s localhost:9901 | grep '^neofs_ir_version'                                                      
zsh: done       curl -s localhost:9901 | 
zsh: exit 1     grep --color=always --initial-tab '^neofs_ir_version'
[sergio@tenes7:~]% s lsof -i -stcp:listen | grep neofs-ir           
neofs-ir  25188        neofs-ir    7u  IPv4 1762578      0t0  TCP localhost:9902 (LISTEN)
neofs-ir  25188        neofs-ir    8u  IPv4 1762582      0t0  TCP localhost:9901 (LISTEN)
[sergio@tenes7:~]% 
[sergio@tenes5:~]% neofs-ir --version
NeoFS Inner Ring node
Version: v0.38.1 
GoVersion: go1.20.4
[sergio@tenes5:~]% curl -s localhost:9901 | grep '^go_info'
go_info{version="go1.20.4"} 1
[sergio@tenes5:~]% curl -s localhost:9901 | grep '^neofs_ir_version'
neofs_ir_version{version="v0.38.1"} 1
[sergio@tenes5:~]% s lsof -i -stcp:listen | grep neofs-ir
neofs-ir    850        neofs-ir    8u  IPv4   15313      0t0  TCP tenes5.nspcc.ru:50333 (LISTEN)
neofs-ir    850        neofs-ir   13u  IPv4   15401      0t0  TCP tenes5.nspcc.ru:50332 (LISTEN)
neofs-ir    850        neofs-ir   14u  IPv4   15402      0t0  TCP tenes5.nspcc.ru:50331 (LISTEN)
neofs-ir    850        neofs-ir   26u  IPv4   15663      0t0  TCP localhost:9901 (LISTEN)
neofs-ir    850        neofs-ir   27u  IPv4   15667      0t0  TCP localhost:9902 (LISTEN)
neofs-ir    850        neofs-ir   29u  IPv4   15759      0t0  TCP localhost:8090 (LISTEN)
[sergio@tenes5:~]% 

@carpawell
Copy link
Member

carpawell commented Dec 15, 2023

Yeah, i see. Well, #2679 should really do the work. It has not been dropped, it is just added after the internal consensus is initiated, the error can't be caught cause there were no internal consensus runs (i did not check it in devenv too). Checked one more time in the AIO with internal consensus and the metrics are ok (not dropped, not overwritten and not any other scary things).

@roman-khimov roman-khimov modified the milestones: v0.40.0, v0.39.1 Dec 15, 2023
@roman-khimov roman-khimov added the neofs-ir Inner Ring node application issues label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working neofs-ir Inner Ring node application issues
Projects
None yet
Development

No branches or pull requests

3 participants