Make NSS test-suite and spec compliant #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* delete root returns 405 * delete root/rootAcl throw 405 * no POST for auxiliary resources * no resource and container with same name * fake commit * reverse fake commit * fake * reverse fake * fake * reverse fake * delete pod * cleaning * cleaning * some more cleaning * content-type must * cleaning * content-type do not default * cleaning * update CRUD checks to solid specifications * PATCH check filename is not a folder * cleaning * pubsub on parent * add PUT for container * cleaning
* delete root/rootAcl * no POST for auxiliary resources * no resource and container with same name except '/' * content-type is a MUST (is it a must for create container ?) * content-type do not default * update CRUD checks to solid specifications * pubsub on parent * add PUT for container * function createDirectory() for PUT PATCH * delete acl from cache if not exists
* PUT do not need req.headers link * make NSS test-suite compliant
bourgeoa
requested review from
jaxoncreed,
michielbdejong,
angelo-v and
RubenVerborgh
|
It looks like this would also fix #1465, is that correct? (If so, great!) |
|
@Vinnl yes this solves #1465 however header link is not needed following @csarven comment in https://gitter.im/solid/test-suite
|
TallTed
reviewed
Jan 19, 2021
TallTed
reviewed
Jan 19, 2021
This was referenced Jan 22, 2021
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR all tests from the test-suite are passing. Considering the following upgrades to be made :
This is a bit large upgrade. I am sorry for it.
The main changes are :
Some more changes to comply with spec :
NSS implementation changes :
This PR + NSS 5.6.0 is running on https://solidcommunity.net:8443 test server with mashlib 1.6.5 latest published version working for long chat.