Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT/POST request with no content-type should fail #1525

Closed
bourgeoa opened this issue Nov 26, 2020 · 1 comment
Closed

PUT/POST request with no content-type should fail #1525

bourgeoa opened this issue Nov 26, 2020 · 1 comment
Assignees

Comments

@bourgeoa
Copy link
Member

@michielbdejong
@jeff-zucker is right, and I have some more details :

  1. jeff code Content-Type - insisting on it as a MUST will create a barrier to adoption solid/specification#211 (comment) do not include a header.

  2. in his code if I add a header and that content-type index do not exist the same result as jeff code arise

  3. if the headers["content-type] and the value is `` or null/undefined then :

    3.1. PUT
    handlers/put : uses utils/getContentType() that returns an application/octet-stream by default. so contentType is never missing

    3.2. POST : do not test if contentType exists, resourceMapper returns an application/octet-stream and when it calls ldp.put contentType and test if contentType do exist in ldp/put. It exists

@bourgeoa bourgeoa self-assigned this Nov 26, 2020
@bourgeoa bourgeoa changed the title PUT/POST request with no header should fail PUT/POST request with no content-type should fail Nov 26, 2020
@bourgeoa
Copy link
Member Author

closed with PR #1557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant