Make NSS test-suite and spec compliant (#1557)

* adds create container with PUT and more (#1543) * delete root returns 405 * delete root/rootAcl throw 405 * no POST for auxiliary resources * no resource and container with same name * fake commit * reverse fake commit * fake * reverse fake * fake * reverse fake * delete pod * cleaning * cleaning * some more cleaning * content-type must * cleaning * content-type do not default * cleaning * update CRUD checks to solid specifications * PATCH check filename is not a folder * cleaning * pubsub on parent * add PUT for container * cleaning * create container with PUT (#1545) * delete root/rootAcl * no POST for auxiliary resources * no resource and container with same name except '/' * content-type is a MUST (is it a must for create container ?) * content-type do not default * update CRUD checks to solid specifications * pubsub on parent * add PUT for container * function createDirectory() for PUT PATCH * delete acl from cache if not exists * PUT do not need req.headers link (#1547) and typos * make NSS test-suite compliant (#1554) * PUT do not need req.headers link * make NSS test-suite compliant * typings : Update lib/acl-checker.js Co-authored-by: Ted Thibodeau Jr <[email protected]> * typings : Update lib/acl-checker.js Co-authored-by: Ted Thibodeau Jr <[email protected]> Co-authored-by: Ted Thibodeau Jr <[email protected]>
nodeSolidServer · Jan 26, 2021 · a8a0857 · a8a0857
1 parent 44e9ce7
commit a8a0857
Show file tree

Hide file tree

Showing 14 changed files with 374 additions and 141 deletions.
diff --git a/lib/acl-checker.js b/lib/acl-checker.js
@@ -1,6 +1,7 @@
 'use strict'
 /* eslint-disable node/no-deprecated-api */
 
+const { dirname } = require('path')
 const rdf = require('rdflib')
 const debug = require('./debug').ACL
 const debugCache = require('./debug').cache
@@ -39,8 +40,8 @@ class ACLChecker {
   }
 
   // Returns a fulfilled promise when the user can access the resource
-  // in the given mode, or rejects with an HTTP error otherwise
-  async can (user, mode) {
+  // in the given mode; otherwise, rejects with an HTTP error
+  async can (user, mode, method = 'GET', resourceExists = true) {
     const cacheKey = `${mode}-${user}`
     if (this.aclCached[cacheKey]) {
       return this.aclCached[cacheKey]
@@ -64,10 +65,10 @@ class ACLChecker {
       resource = rdf.sym(this.resource.substring(0, this.resource.length - this.suffix.length))
     }
     // If the slug is an acl, reject
-    if (this.isAcl(this.slug)) {
+    /* if (this.isAcl(this.slug)) {
       this.aclCached[cacheKey] = Promise.resolve(false)
       return this.aclCached[cacheKey]
-    }
+    } */
     const directory = acl.isContainer ? rdf.sym(ACLChecker.getDirectory(acl.acl)) : null
     const aclFile = rdf.sym(acl.acl)
     const agent = user ? rdf.sym(user) : null
@@ -84,7 +85,19 @@ class ACLChecker {
       // FIXME: https://github.com/solid/acl-check/issues/23
       // console.error(e.message)
     }
-    const accessDenied = aclCheck.accessDenied(acl.graph, resource, directory, aclFile, agent, modes, agentOrigin, trustedOrigins, originTrustedModes)
+    let accessDenied = aclCheck.accessDenied(acl.graph, resource, directory, aclFile, agent, modes, agentOrigin, trustedOrigins, originTrustedModes)
+
+    // For create and update HTTP methods
+    if ((method === 'PUT' || method === 'PATCH' || method === 'COPY') && directory) {
+      // if resource and acl have same parent container,
+      // and resource does not exist, then accessTo Append from parent is required
+      if (directory.value === dirname(aclFile.value) + '/' && !resourceExists) {
+        const accessDeniedAccessTo = aclCheck.accessDenied(acl.graph, directory, null, aclFile, agent, [ACL('Append')], agentOrigin, trustedOrigins, originTrustedModes)
+        const accessResult = !accessDenied && !accessDeniedAccessTo
+        accessDenied = accessResult ? false : accessDenied || accessDeniedAccessTo
+        // debugCache('accessDenied result ' + accessDenied)
+      }
+    }
     if (accessDenied && user) {
       this.messagesCached[cacheKey].push(HTTPError(403, accessDenied))
     } else if (accessDenied) {
@@ -96,6 +109,7 @@ class ACLChecker {
 
   async getError (user, mode) {
     const cacheKey = `${mode}-${user}`
+    // TODO ?? add to can: req.method and resourceExists.  Actually all tests pass
     this.aclCached[cacheKey] = this.aclCached[cacheKey] || this.can(user, mode)
     const isAllowed = await this.aclCached[cacheKey]
     return isAllowed ? null : this.messagesCached[cacheKey].reduce((prevMsg, msg) => msg.status > prevMsg.status ? msg : prevMsg, { status: 0 })
@@ -206,6 +220,8 @@ function fetchLocalOrRemote (mapper, serverUri) {
       try {
         ({ path, contentType } = await mapper.mapUrlToFile({ url }))
       } catch (err) {
+        // delete from cache
+        delete temporaryCache[url]
         throw new HTTPError(404, err)
       }
       // Read the file from disk
@@ -220,10 +236,10 @@ function fetchLocalOrRemote (mapper, serverUri) {
   }
   return async function fetch (url, graph = rdf.graph()) {
     if (!temporaryCache[url]) {
-      debugCache('Populating cache', url)
+      // debugCache('Populating cache', url)
       temporaryCache[url] = {
         timer: setTimeout(() => {
-          debugCache('Expunging from cache', url)
+          // debugCache('Expunging from cache', url)
           delete temporaryCache[url]
           if (Object.keys(temporaryCache).length === 0) {
             debugCache('Cache is empty again')
@@ -232,7 +248,7 @@ function fetchLocalOrRemote (mapper, serverUri) {
         promise: doFetch(url)
       }
     }
-    debugCache('Cache hit', url)
+    // debugCache('Cache hit', url)
     const { body, contentType } = await temporaryCache[url].promise
     // Parse the file as Turtle
     rdf.parse(body, graph, url, contentType)
@@ -248,7 +264,8 @@ function lastSlash (string, pos = string.length) {
 module.exports = ACLChecker
 module.exports.DEFAULT_ACL_SUFFIX = DEFAULT_ACL_SUFFIX
 
-// Used in the unit tests:
-module.exports.clearAclCache = function () {
-  temporaryCache = {}
+// Used in ldp and the unit tests:
+module.exports.clearAclCache = function (url) {
+  if (url) delete temporaryCache[url]
+  else temporaryCache = {}
 }
diff --git a/lib/handlers/allow.js b/lib/handlers/allow.js
@@ -1,10 +1,11 @@
 module.exports = allow
 
-const path = require('path')
+// const path = require('path')
 const ACL = require('../acl-checker')
 const debug = require('../debug.js').ACL
+// const error = require('../http-error')
 
-function allow (mode, checkPermissionsForDirectory) {
+function allow (mode) {
   return async function allowHandler (req, res, next) {
     const ldp = req.app.locals.ldp || {}
     if (!ldp.webid) {
@@ -20,11 +21,6 @@ function allow (mode, checkPermissionsForDirectory) {
       ? res.locals.path
       : req.path
 
-    // Check permissions of the directory instead of the file itself.
-    if (checkPermissionsForDirectory) {
-      resourcePath = path.dirname(resourcePath)
-    }
-
     // Check whether the resource exists
     let stat
     try {
@@ -49,7 +45,7 @@ function allow (mode, checkPermissionsForDirectory) {
 
     // Ensure the user has the required permission
     const userId = req.session.userId
-    const isAllowed = await req.acl.can(userId, mode)
+    const isAllowed = await req.acl.can(userId, mode, req.method, stat)
     if (isAllowed) {
       return next()
     }

diff --git a/lib/handlers/delete.js b/lib/handlers/delete.js
@@ -13,6 +13,11 @@ async function handler (req, res, next) {
     next()
   } catch (err) {
     debug('DELETE -- Failed to delete: ' + err)
+
+    // method DELETE not allowed
+    if (err.status === 405) {
+      res.set('allow', 'OPTIONS, HEAD, GET, PATCH, POST, PUT')
+    }
     next(err)
   }
 }
diff --git a/lib/handlers/error-pages.js b/lib/handlers/error-pages.js
@@ -147,7 +147,8 @@ function renderLoginRequired (req, res, err) {
  */
 function renderNoPermission (req, res, err) {
   const currentUrl = util.fullUrlForReq(req)
-  const webId = req.session.userId
+  let webId = ''
+  if (req.session) webId = req.session.userId
   debug(`Display no-permission for ${currentUrl}`)
   res.statusMessage = err.message
   res.status(403)

diff --git a/lib/handlers/patch.js b/lib/handlers/patch.js
@@ -4,16 +4,13 @@ module.exports = handler
 
 const bodyParser = require('body-parser')
 const fs = require('fs')
-const mkdirp = require('fs-extra').mkdirp
 const debug = require('../debug').handlers
 const error = require('../http-error')
 const $rdf = require('rdflib')
 const crypto = require('crypto')
 const overQuota = require('../utils').overQuota
 const getContentType = require('../utils').getContentType
 const withLock = require('../lock')
-const { promisify } = require('util')
-const pathUtility = require('path')
 
 // Patch parsers by request body content type
 const PATCH_PARSERS = {
@@ -31,13 +28,17 @@ async function patchHandler (req, res, next) {
     // Obtain details of the target resource
     const ldp = req.app.locals.ldp
     let path, contentType
+    let resourceExists = true
     try {
       // First check if the file already exists
       ({ path, contentType } = await ldp.resourceMapper.mapUrlToFile({ url: req }))
     } catch (err) {
       // If the file doesn't exist, request one to be created with the default content type
       ({ path, contentType } = await ldp.resourceMapper.mapUrlToFile(
         { url: req, createIfNotExists: true, contentType: DEFAULT_FOR_NEW_CONTENT_TYPE }))
+      // check if a folder with same name exists
+      await ldp.checkItemName(req)
+      resourceExists = false
     }
     const { url } = await ldp.resourceMapper.mapFileToUrl({ path, hostname: req.hostname })
     const resource = { path, contentType, url }
@@ -56,26 +57,10 @@ async function patchHandler (req, res, next) {
 
     // Parse the patch document and verify permissions
     const patchObject = await parsePatch(url, patch.uri, patch.text)
-    await checkPermission(req, patchObject)
-
-    // Check to see if folder exists
-    const pathSplit = path.split('/')
-    const directory = pathSplit.slice(0, pathSplit.length - 1).join('/')
-    if (!fs.existsSync(directory)) {
-      const firstDirectoryRecursivelyCreated = await promisify(mkdirp)(directory)
-      if (ldp.live) {
-        // Get parent for the directory made
-        const parentDirectoryPath =
-          pathUtility.dirname(firstDirectoryRecursivelyCreated) + pathUtility.sep
-        // Get the url for the parent
-        const parentDirectoryUrl = (await ldp.resourceMapper.mapFileToUrl({
-          path: parentDirectoryPath,
-          hostname: req.hostname
-        })).url
-        // Update websockets
-        ldp.live(new URL(parentDirectoryUrl).pathname)
-      }
-    }
+    await checkPermission(req, patchObject, resourceExists)
+
+    // Create the enclosing directory, if necessary
+    await ldp.createDirectory(path, req.hostname)
 
     // Patch the graph and write it back to the file
     const result = await withLock(path, async () => {
@@ -133,28 +118,31 @@ function readGraph (resource) {
 }
 
 // Verifies whether the user is allowed to perform the patch on the target
-async function checkPermission (request, patchObject) {
+async function checkPermission (request, patchObject, resourceExists) {
   // If no ACL object was passed down, assume permissions are okay.
   if (!request.acl) return Promise.resolve(patchObject)
   // At this point, we already assume append access,
   // as this can be checked upfront before parsing the patch.
   // Now that we know the details of the patch,
   // we might need to perform additional checks.
   let modes = []
+  // acl:default Write is required for create
+  if (!resourceExists) modes = ['Write']
   const { acl, session: { userId } } = request
   // Read access is required for DELETE and WHERE.
   // If we would allows users without read access,
   // they could use DELETE or WHERE to trigger 200 or 409,
   // and thereby guess the existence of certain triples.
   // DELETE additionally requires write access.
   if (patchObject.delete) {
+    // ACTUALLY Read not needed by solid/test-suite only Write
     modes = ['Read', 'Write']
     // checks = [acl.can(userId, 'Read'), acl.can(userId, 'Write')]
   } else if (patchObject.where) {
-    modes = ['Read']
+    modes = modes.concat(['Read'])
     // checks = [acl.can(userId, 'Read')]
   }
-  const allowed = await Promise.all(modes.map(mode => acl.can(userId, mode)))
+  const allowed = await Promise.all(modes.map(mode => acl.can(userId, mode, request.method, resourceExists)))
   const allAllowed = allowed.reduce((memo, allowed) => memo && allowed, true)
   if (!allAllowed) {
     const errors = await Promise.all(modes.map(mode => acl.getError(userId, mode)))

diff --git a/lib/handlers/put.js b/lib/handlers/put.js
@@ -18,17 +18,18 @@ async function handler (req, res, next) {
   return putStream(req, res, next)
 }
 
+// TODO could be renamed as putResource (it now covers container and non-container)
 async function putStream (req, res, next, stream = req) {
   const ldp = req.app.locals.ldp
   try {
+    debug('test ' + req.get('content-type') + getContentType(req.headers))
     await ldp.put(req, stream, getContentType(req.headers))
-    debug('succeded putting the file')
-
+    debug('succeded putting the file/folder')
     res.sendStatus(201)
     return next()
   } catch (err) {
-    debug('error putting the file:' + err.message)
-    err.message = 'Can\'t write file: ' + err.message
+    debug('error putting the file/folder:' + err.message)
+    err.message = 'Can\'t write file/folder: ' + err.message
     return next(err)
   }
 }

diff --git a/lib/ldp-middleware.js b/lib/ldp-middleware.js
@@ -26,7 +26,7 @@ function LdpMiddleware (corsSettings) {
   router.post('/*', allow('Append'), post)
   router.patch('/*', allow('Append'), patch)
   router.put('/*', allow('Write'), put)
-  router.delete('/*', allow('Write', true), del)
+  router.delete('/*', allow('Write'), del)
 
   return router
 }