-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve config and reduce fulltest #163
Conversation
@@ -40,5 +41,5 @@ params { | |||
phase = false | |||
|
|||
// Impute tools | |||
tools = "glimpse1" | |||
tools = "glimpse2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? I am confused as the reason behind this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, we are going to launch a completely different AWS mega test from the one before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aim is to reduce the computational cost of the megatest as much as possible.
The glimpse2
software as less steps (no variant calling) and should also be more computationally efficient.
I'll add it to the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I may have some reservations about these changes, I also don’t want to block progress toward the release. I trust your verification that the full glimpse2
megatest works, that it is less computationally expensive, and aligns with the new genome in a bottle VCF :)
I've checked on my cluster on a subset and everything worked perfectly ;) |
The truth variants set of NA12878 is now the one computed by Genome in a Bottle.
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).