-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: another cleanup and linting (contains move to configfiles) #478
Conversation
f2b9eba
to
124e563
Compare
This is too big of a commit to be a patch change. This should be a minor or major change, but I think it might be best to avoid these massive PRs in the future, as they're hard to review. People use this helm chart for important personal and professional aims, and we should try to make PRs as clear and concise as possible, to help others debug any potential bugs that may arise. Please instead target specific and small changes. |
I understand your position, for the future i will make it - i has already said in my PSS, that i will create smaller PRs. So what should i do with this PR now. |
Let's do specific small PRs and close this one for now. We still need to test and fix the bug from the other day before doing more clean up though as the chart is currently broken on the latest version. Thank you for understanding |
2f5a084
to
f16feec
Compare
Signed-off-by: WrenIX <[email protected]>
Signed-off-by: WrenIX <[email protected]>
Signed-off-by: WrenIX <[email protected]>
Signed-off-by: WrenIX <[email protected]>
Signed-off-by: WrenIX <[email protected]>
here are still two commits, with another cleanup |
If there are still two smaller commits left on this repo, could you please isolate them and explain what they do in the PR description, and then I can reopen this, or you can option a new PR, up to you. |
few parts cleanup and lint
contains commit of:
Checklist
Chart.yaml
according to semver.