fix: another cleanup and linting #484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrenix
force-pushed
the
fix/small-parts
branch
2 times, most recently
from
3c70c46 to
7d192b0
Compare
2 tasks
wrenix
changed the title
wrenix
force-pushed
the
fix/small-parts
branch
from
7d192b0 to
4189f72
Compare
Signed-off-by: WrenIX <[email protected]>
wrenix
force-pushed
the
fix/small-parts
branch
from
4189f72 to
9f40af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
last split of #478
Benefits
readable code
Possible drawbacks
none
Additional information
I am willing to split that in smaller parts, but first merge my last small parts like:
i really stuck in how slow the last things are reviewed here
Checklist
Chart.yamlaccording to semver.