-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move metrics yaml to extra folder #516
Conversation
I understand you are frustrated, but please stay friendly towards others https://nextcloud.com/contribute/code-of-conduct/ |
Honestly I'm not sure if this change makes sense. According to https://helm.sh/docs/chart_best_practices/templates/ the current structure is best practice and the page doesn't mention that subdirectories are allowed (but it also doesn't say they are not allowed). https://stackoverflow.com/a/77619725 suggests that it still works, even if it is not documented. |
your first link is good, but it does not say anything about, if much of your stackoverflow post, say - that it works (and yes it works also for application charts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, I see that is change makes sense to make the structure less cluttered.
that change does not change any logic -> semver a chore, which does not need a new version, but maybe your ci failed ... |
CI is still running, I'm not sure if it will require a new version 🤔 |
Signed-off-by: WrenIX <[email protected]>
it needs: https://github.com/nextcloud/helm/actions/runs/7754331260/job/21148125372?pr=516 |
a first / last try of a really easy reviewable PR
if you see this and need more then 5min ....
@provokateurin
a split of #481 which is an split of #478 (which does not contain any changes in logic and is 2,5 month old)