Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move metrics yaml to extra folder #516

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

wrenix
Copy link
Collaborator

@wrenix wrenix commented Feb 2, 2024

a first / last try of a really easy reviewable PR

if you see this and need more then 5min ....

@provokateurin

a split of #481 which is an split of #478 (which does not contain any changes in logic and is 2,5 month old)

@provokateurin
Copy link
Member

I understand you are frustrated, but please stay friendly towards others https://nextcloud.com/contribute/code-of-conduct/

@provokateurin
Copy link
Member

Honestly I'm not sure if this change makes sense. According to https://helm.sh/docs/chart_best_practices/templates/ the current structure is best practice and the page doesn't mention that subdirectories are allowed (but it also doesn't say they are not allowed). https://stackoverflow.com/a/77619725 suggests that it still works, even if it is not documented.

@wrenix
Copy link
Collaborator Author

wrenix commented Feb 2, 2024

your first link is good, but it does not say anything about, if much of my-example exists and nothing about folders inside of templates.

your stackoverflow post, say - that it works (and yes it works also for application charts).

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, I see that is change makes sense to make the structure less cluttered.

@wrenix
Copy link
Collaborator Author

wrenix commented Feb 2, 2024

that change does not change any logic -> semver a chore, which does not need a new version, but maybe your ci failed ...

@provokateurin
Copy link
Member

CI is still running, I'm not sure if it will require a new version 🤔

@wrenix
Copy link
Collaborator Author

wrenix commented Feb 2, 2024

@wrenix wrenix mentioned this pull request Feb 2, 2024
@provokateurin provokateurin merged commit ef41d75 into nextcloud:main Feb 2, 2024
2 checks passed
@wrenix wrenix deleted the chore/metrics branch February 2, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants