chore: lint all templates to fix indentation and update style

[wrenix]

Pull Request

Description of the change

• replace indent with nindent (and spaces)
• array of yaml indent
• with+if replace with with (with is already an if)
• nginx if over all probes
• use more with
• default "just" in values.yaml

Benefits

readable code

Possible drawbacks

none

Applicable issues

none

Additional information

• DCO has been signed off on the commit.
• Chart version bumped in Chart.yaml according to semver.
• (optional) Variables are documented in the README.md

[jessebot]

Left a few comments, but overall good linting/formatting changes :) What did you use to do this and in which text editor/IDE?

[jessebot]

Can you also bump this a patch version in the Chart.yaml? I know it's just linting and formatting, but it's always helpful, just in case.

[wrenix]

sadly i do that handly and use the https://helix-editor.com/ - but i see that not readible code very often (and start sometimes with some cleanups before i work there)

PS: i am thinking of createn an PR, to manage nextcoud-apps and there configuration with an initcontainer and script using occ-commands ...

[jessebot]

sadly i do that handly and use the https://helix-editor.com/ - but i see that not readible code very often (and start sometimes with some cleanups before i work there)

well you did a good job! also that editor looks neat :)

PS: i am thinking of createn an PR, to manage nextcoud-apps and there configuration with an initcontainer and script using occ-commands ...

please see this comment as apparently we already have a post install task mechanism here?:
#272 (comment)

update: just realized you're in that thread too 😄

It would be great to get some docs on that though!

[wrenix]

so i hope for the first step, i have everything solved.

PS: I create a discussion issue for my idea of application management, see #466

[jessebot]

This looks good to me and I learned some stuff along the way, which is always awesome! Due to the size of this PR, I'm going to tag in a couple of other collaborators to review this and make sure I didn't miss anything.

[provokateurin]

LGTM, just some whitespace nitpicks

[DanishVaid]

@wrenix I think this introduced a regression. The change in charts/nextcloud/templates/config.yaml line 14 from indent -> nindent causes an extra newline and that leads to a PHP error:

Config file has leading content, please remove everything before "<?php" in custom.config.php
Fatal error: Uncaught Error: Typed static property OC::$server must not be accessed before initialization in /var/www/html/index.php:71 Stack trace: #0 {main} thrown in /var/www/html/index.php on line 71