Allow NGINX additional config

[FlorentPoinsaut]

Pull Request

Description of the change

Use the original nginx.conf file to allow additional config.

.Values.nginx.config.custom doesn't override the default value anymore, it adds.

Benefits

Example: ability to enable NGINX status page.

Possible drawbacks

Applicable issues

• fixes #

Additional information

Checklist

• DCO has been signed off on the commit.
• Chart version bumped in Chart.yaml according to semver.
• (optional) Variables are documented in the README.md

[jessebot]

@FlorentPoinsaut can you please rebase your PR to get the latest changes and bump the helm chart version?

dismissing stale review but can't approve till tests have run

[jessebot]

Have you tested this already?

[FlorentPoinsaut]

Yes @jessebot, it's currently on production in one of my hosting.

[jessebot]

Looks good to me, but tagging in a couple of other reviewers just so I didn't miss anything because I still don't have to time to test this 🙏 Seems valid though. @provokateurin or @tvories feel free to merge if you also approve.

[jessebot]

@FlorentPoinsaut we merged #465 and #476 for linting prior to this, and so you may need to rebase again. I'm sorry :(

[FlorentPoinsaut]

Done @jessebot

[jessebot]

@tvories and @provokateurin this has been open a while, so I'd like to merge it. Letting you both know as this is a bigger change to nginx. It looks ok to me, but if it breaks anything, we'd probably get users reporting in issues fairly quickly and we'd need to roll back, as nginx is a very common parameter to enable. It does seem fine though.

[FlorentPoinsaut]

Thanks @jessebot!

[jessebot]

@FlorentPoinsaut thanks for all your patience on this! Feels good to finally get this merged :)

Extermely minor note: In the future, please allow edits by maintainers on your PRs so that we can update them and move them forward. And again, sorry for this taking so long!

[wrenix]

indent golang like yaml + use with instatt of if

Suggested change

	{{- if .Values.nginx.config.custom }}
	{{- with .Values.nginx.config.custom }}
	zz-custom.conf: |-
	{{ . | nindent 4 }j
	{{- end }]