Derive ReachabilityFlags traits (that were removed by bitflags upgrade)
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade from bitflags 1 -> 2 removed them In total we lose the Ord/PartialOrd implementations. But those did not make any sense for this type anyway, so that's good. But breaking.
dlon
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade of
bitflagsfrom1to2in #45 removed a lot of automatically derived traits. I found this withcargo semver-checks. This PR adds many of them back! Because these derivations make sense. However, we still lose the derivation ofOrdandPartialOrdthatbitflags 1automatically derived. This is fine to lose however, since ordering of flags did not make much sense. It is a breaking change nonetheless.The bitflags upgrade also replaces an unsafe constructor with a bunch of safe ones.
Also add the changelog entry for this upgrade.
This change is