Merge branch 'derive-reachability-flags-traits'

mullvad · Jan 31, 2024 · f4096d1 · f4096d1
2 parents fe56d19 + 83ce40f
commit f4096d1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -27,6 +27,8 @@ Line wrap the file at 100 chars.                                              Th
 - Breaking: Mark `SCNetworkReachability::schedule_with_runloop` and `unschedule_from_runloop` as
   `unsafe`. They accept a raw pointer that it dereferences. Figuring out a safe API around this is
   left as an exercise for the future.
+- Breaking: `ReachabilityFlags` no longer implements `Ord` or `PartialOrd`. It also replaces the
+  `from_bits_unchecked` constructor with other (safe) `from_bits_*` constructors.
 
 ### Fixed
 - Fix memory leak in `SCNetworkReachability::set_callback`.

diff --git a/system-configuration/src/network_reachability.rs b/system-configuration/src/network_reachability.rs
@@ -85,6 +85,7 @@ bitflags::bitflags! {
     /// Rustier interface for [`SCNetworkReachabilityFlags`].
     ///
     /// [`SCNetworkReachability`]: https://developer.apple.com/documentation/systemconfiguration/scnetworkreachabilityflags
+    #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
     pub struct ReachabilityFlags: u32 {
         /// The specified node name or address can be reached via a transient connection, such as
         /// PPP.