Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive ReachabilityFlags traits (that were removed by bitflags upgrade) #48

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Derive ReachabilityFlags traits (that were removed by bitflags upgrade) #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08a62bd
Derive Debug, Copy, Eq, Hash etc on ReachabilityFlag
faern Jan 31, 2024
83ce40f
Add changelog about changes to ReachabilityFlags
faern Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ Line wrap the file at 100 chars. Th
- Breaking: Mark `SCNetworkReachability::schedule_with_runloop` and `unschedule_from_runloop` as
`unsafe`. They accept a raw pointer that it dereferences. Figuring out a safe API around this is
left as an exercise for the future.
- Breaking: `ReachabilityFlags` no longer implements `Ord` or `PartialOrd`. It also replaces the
`from_bits_unchecked` constructor with other (safe) `from_bits_*` constructors.

### Fixed
- Fix memory leak in `SCNetworkReachability::set_callback`.
Expand Down
1 change: 1 addition & 0 deletions system-configuration/src/network_reachability.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ bitflags::bitflags! {
/// Rustier interface for [`SCNetworkReachabilityFlags`].
///
/// [`SCNetworkReachability`]: https://developer.apple.com/documentation/systemconfiguration/scnetworkreachabilityflags
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub struct ReachabilityFlags: u32 {
/// The specified node name or address can be reached via a transient connection, such as
/// PPP.
Expand Down
Loading