Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sssom support #109

Merged
merged 20 commits into from
Oct 24, 2023
Merged

adding sssom support #109

merged 20 commits into from
Oct 24, 2023

Conversation

glass-ships
Copy link
Collaborator

@glass-ships glass-ships commented May 22, 2023

addresses #108
fix #110

Tasks:

  • Add SSSOM mapping functionality in Koza writers
  • Still need to do something else
  • Add testing (still need narrow match and broad match tests, but in another PR)
  • Update documentation
  • Clarify existing examples (this can/should probably be a separate issue) see Clarify examples #113
  • Add example w/ sssom config

@glass-ships glass-ships self-assigned this May 22, 2023
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just lurking feel free to ignore comments

pyproject.toml Outdated Show resolved Hide resolved
src/koza/cli_runner.py Show resolved Hide resolved
src/koza/model/config/source_config.py Outdated Show resolved Hide resolved
@glass-ships glass-ships mentioned this pull request Jun 12, 2023
6 tasks
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the config live that says: "use narrow matches for node replacement" vs "us only exact matches for node replacement"?

pyproject.toml Outdated Show resolved Hide resolved
src/koza/model/config/source_config.py Outdated Show resolved Hide resolved
src/koza/model/config/source_config.py Outdated Show resolved Hide resolved
src/koza/model/config/source_config.py Outdated Show resolved Hide resolved
@glass-ships
Copy link
Collaborator Author

Where does the config live that says: "use narrow matches for node replacement" vs "us only exact matches for node replacement"?

I... don't know if we have one, to be honest

@glass-ships
Copy link
Collaborator Author

Oh, so in response to the config question- I think for now we might just bring this in with only "exact match", and open it up to include narrow in another PR

@matentzn
Copy link
Member

matentzn commented Sep 5, 2023

Restricting to exact sounds good as a first safe step, but you may loose quite a bit of relevant Information. I think it's worth making that configurable via some property like "merge_on_property".

@glass-ships
Copy link
Collaborator Author

nice one @hrshdhgd thanks for taking a look at that!!

@glass-ships
Copy link
Collaborator Author

is there anything preventing this from being merged as is?

@glass-ships glass-ships requested a review from matentzn October 24, 2023 20:44
@glass-ships
Copy link
Collaborator Author

There's a lot of formatting noise in this now, but the relevant changes are in:

  • model/config/sssom_config.py
  • tsv_writer
  • jsonl_writer
  • example usage in tests/unit/test_sssom_mapping.py

@glass-ships glass-ships merged commit 718d045 into main Oct 24, 2023
4 checks passed
@glass-ships glass-ships deleted the develop branch October 24, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Produce friendlier error from csv_reader on missing column
4 participants