Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove openapi-v3 from apiconnect dependencies #5927

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jul 13, 2020

Use @loopback/rest to access openapi-related types and helpers.

This pull request is a part of #5692.

BREAKING CHANGE: @loopback/core and @loopback/rest were moved to peer dependencies, to ensure the extension uses application's version of these modules. If this change breaks your application (which is unlikely), then simply add both @loopback/core and @loopback/rest to your project dependencies.

I am observing timeouts when running the tests locally (even on master), I think they are not related to my changes and will rely on CI builds to confirm.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@bajtos bajtos requested a review from raymondfeng July 13, 2020 14:51
@bajtos bajtos requested a review from deepakrkris as a code owner July 13, 2020 14:51
@bajtos bajtos self-assigned this Jul 13, 2020
@bajtos bajtos changed the title feat: remove openapi-v3 from apiconnect depenendencies feat: remove openapi-v3 from apiconnect dependencies Jul 13, 2020
@bajtos bajtos force-pushed the feat/remove-openapi-from-apiconnect branch from 2b21592 to f4559e0 Compare July 13, 2020 14:54
@bajtos
Copy link
Member Author

bajtos commented Jul 14, 2020

@raymondfeng thank you for the comment above. How to move this pull request forward? Are you fine with the proposed approach or would you like me to rework the patch to avoid introduction of peer dependencies? Something else?

@raymondfeng
Copy link
Contributor

Here is my personal preference but I won't block you from merging this PR as is.

  1. Simply remove @loopback/openapi-v3 without changing to peerDependencies in this PR.
  2. Having a follow-up PR to universally switch to peerDependencies for all extension-like packages.

Use `@loopback/rest` to access openapi-related types and helpers.

Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos force-pushed the feat/remove-openapi-from-apiconnect branch from f4559e0 to 72ae24c Compare July 16, 2020 06:21
@bajtos
Copy link
Member Author

bajtos commented Jul 16, 2020

  1. Simply remove @loopback/openapi-v3 without changing to peerDependencies in this PR.
  2. Having a follow-up PR to universally switch to peerDependencies for all extension-like packages.

That's a good plan 👍

I cannot simply remove @loopback/openapi-v3 from dependencies, I need to move @loopback/rest from dev-dependencies to regular dependencies to avoid the situation when import statement is referencing a dependency that is not available.

@raymondfeng LGTY now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants