-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove openapi-v3 from apiconnect dependencies #5927
Conversation
2b21592
to
f4559e0
Compare
@raymondfeng thank you for the comment above. How to move this pull request forward? Are you fine with the proposed approach or would you like me to rework the patch to avoid introduction of peer dependencies? Something else? |
Here is my personal preference but I won't block you from merging this PR as is.
|
Use `@loopback/rest` to access openapi-related types and helpers. Signed-off-by: Miroslav Bajtoš <[email protected]>
f4559e0
to
72ae24c
Compare
That's a good plan 👍 I cannot simply remove @raymondfeng LGTY now? |
Use
@loopback/rest
to access openapi-related types and helpers.This pull request is a part of #5692.
BREAKING CHANGE:@loopback/core
and@loopback/rest
were moved to peer dependencies, to ensure the extension uses application's version of these modules. If this change breaks your application (which is unlikely), then simply add both@loopback/core
and@loopback/rest
to your project dependencies.I am observing timeouts when running the tests locally (even on master), I think they are not related to my changes and will rely on CI builds to confirm.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈