feat: move framework packages to peerDependencies
#6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: components no longer install core framework packages as their own dependencies, they use the framework packages provided by the target application instead. If you are getting `npm install` errors after upgrade, then make sure your project lists all dependencies required by the extensions you are using. Signed-off-by: Miroslav Bajtoš <[email protected]>
Update `packages/*/package.json` to ensure consistent order of the following metadata: 1. `peerDependencies` 2. `dependencies` 3. `devDependencies` Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
requested review from
agnes512,
emonddr,
hacksparrow,
jannyHou and
nabdelgadir
as code owners
6 tasks
raymondfeng
approved these changes
Sep 7, 2020
There was a problem hiding this comment.
Can you improve https://github.com/strongloop/loopback-next/blob/master/bin/check-package-metadata.js to make sure our extension packages always follow the same convention?
That's a great idea! I'll open a new pull request for that, later this week or next week. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the last spin-off from #5959 which was too difficult to get landed because of merge conflicts. In this patch, I have updated dependencies in all
extension/*packages.Please read #5959 for the original discussion around this proposal. We have reached consensus to follow this new direction, so I hope we can get this PR landed quickly.
The first commit moves dependencies to
peerDependencies. The second commit is a small cleanup to ensure allpackage/*/package.jsonfiles are using the same order ofpeerDependencies,dependenciesanddevDependencies.Close #5959
BREAKING CHANGE
Components no longer install core framework packages as their own dependencies, they use the framework packages provided by the target application instead.
If you are getting
npm installerrors after upgrade, then make sure your project lists all dependencies required by the extensions you are using.Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈