Skip to content

Commit

Permalink
feat: remove openapi-v3 from apiconnect depenendencies
Browse files Browse the repository at this point in the history
BREAKING CHANGE: `@loopback/core` and `@loopback/rest` were moved to
peer dependencies, to ensure the extension uses application's version
of these modules. If this change breaks your application (which is
unlikely), then simply add both `@loopback/core` and `@loopback/rest`
to your project dependencies.

Signed-off-by: Miroslav Bajtoš <[email protected]>
  • Loading branch information
bajtos committed Jul 13, 2020
1 parent 9619394 commit 2b21592
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
7 changes: 5 additions & 2 deletions extensions/apiconnect/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,15 @@
"directory": "extensions/apiconnect"
},
"dependencies": {
"@loopback/core": "^2.9.1",
"@loopback/openapi-v3": "^3.4.5",
"tslib": "^2.0.0"
},
"peerDependencies": {
"@loopback/core": "^2.9.1",
"@loopback/rest": "^5.2.0"
},
"devDependencies": {
"@loopback/build": "^6.1.0",
"@loopback/core": "^2.9.1",
"@loopback/eslint-config": "^8.0.3",
"@loopback/rest": "^5.2.0",
"@loopback/testlab": "^3.2.0",
Expand Down
2 changes: 1 addition & 1 deletion extensions/apiconnect/src/apiconnect.spec-enhancer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
CoreBindings,
inject,
} from '@loopback/core';
import {asSpecEnhancer, OASEnhancer, OpenAPIObject} from '@loopback/openapi-v3';
import {asSpecEnhancer, OASEnhancer, OpenAPIObject} from '@loopback/rest';

/**
* Configuration for IBM API Connect extensions to the OpenAPI spec
Expand Down
3 changes: 0 additions & 3 deletions extensions/apiconnect/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
{
"path": "../../packages/core/tsconfig.json"
},
{
"path": "../../packages/openapi-v3/tsconfig.json"
},
{
"path": "../../packages/rest/tsconfig.json"
},
Expand Down

0 comments on commit 2b21592

Please sign in to comment.