Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce info and warning common utilities #1188

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Introduce info and warning common utilities #1188

merged 6 commits into from
Jan 10, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Dec 15, 2023 •
edited
Loading

Description

Introduce info and warning common utilities and refactor the usage of the Console functions

Additional context

Issue reference

https://jira.lmc.cz/browse/DS-767

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify Netlify
Copy link

netlify bot commented Dec 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 77b4906
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/659bca66f5c3970008bed894

@github-actions github-actions bot added the feature New feature or request label Dec 15, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 77b4906
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/659bca665fce7800086d3abd
😎 Deploy Preview https://deploy-preview-1188--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat mentioned this pull request Dec 15, 2023
Merged
4 tasks
adamkudrna
adamkudrna approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd only wish to improve the disabling comments so they have the reason right after them. Otherwise looks good to me. 👍🏻

packages/common/utilities/warning.ts Outdated Show resolved Hide resolved
packages/common/utilities/warning.ts Outdated Show resolved Hide resolved
packages/common/utilities/warning.ts Show resolved Hide resolved
packages/common/utilities/info.ts Outdated Show resolved Hide resolved
packages/common/utilities/__tests__/warning.test.ts Outdated Show resolved Hide resolved
@literat literat force-pushed the feat/visual-test-locally branch from 37707e1 to f9e4b16 Compare January 2, 2024 13:29
@literat literat mentioned this pull request Jan 2, 2024
Merged
4 tasks
@literat literat force-pushed the feat/visual-test-locally branch from f9e4b16 to ecf4b82 Compare January 2, 2024 14:00
Base automatically changed from feat/visual-test-locally to main January 2, 2024 14:28
@literat literat force-pushed the feat/DS-767-warning-utility branch from 734a7c4 to 087a726 Compare January 5, 2024 15:15
@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 77b4906
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/659bca66127f810008583d7e
😎 Deploy Preview https://deploy-preview-1188--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 77b4906
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/659bca6678cd2b0008ccdb50

@coveralls
Copy link

coveralls commented Jan 5, 2024 •
edited
Loading

Coverage Status

coverage: 79.867% (+0.2%) from 79.697%
when pulling 77b4906 on feat/DS-767-warning-utility
into 6335a67 on main.

@literat literat force-pushed the feat/DS-767-warning-utility branch from 53350f6 to e1c4f74 Compare January 8, 2024 09:45
@literat literat merged commit afb2bfc into main Jan 10, 2024
22 checks passed
@literat literat deleted the feat/DS-767-warning-utility branch January 10, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen left review comments

@adamkudrna adamkudrna adamkudrna approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@literat literat

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@literat @coveralls @adamkudrna @crishpeen