Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CQT and fix some lint errors #1187

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Upgrade CQT and fix some lint errors #1187

merged 2 commits into from
Jan 10, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Dec 14, 2023

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 9949ffc
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/659ebe1a81b8aa0008f7a37f

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 9949ffc
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/659ebe1a2fa397000813781b

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 9949ffc
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/659ebe1a095ff900088265e6

@netlify Netlify
Copy link

netlify bot commented Dec 14, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 9949ffc
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/659ebe1a3649a400083440e1

adamkudrna
adamkudrna approved these changes Dec 14, 2023
View reviewed changes
packages/web/src/js/FileUploader.ts Outdated Show resolved Hide resolved
packages/web/src/js/utils/__tests__/Config.test.ts Outdated Show resolved Hide resolved
@literat literat added maintenance Changes to the build process or auxilary tools and libraries or other maintenance blocked Issues blocked by issue we cannot affect labels Dec 15, 2023
@literat
Copy link
Collaborator Author

literat commented Dec 15, 2023

This is now blocked and partially solved by #1188

@literat literat force-pushed the dependencies/upgrade-cqt branch from 18cd0ee to 43a8f2c Compare January 10, 2024 15:19
@coveralls
Copy link

coveralls commented Jan 10, 2024 •
edited
Loading

Coverage Status

coverage: 79.979% (+3.5%) from 76.515%
when pulling 9949ffc on dependencies/upgrade-cqt
into f8e8653 on main.

@literat literat force-pushed the dependencies/upgrade-cqt branch 2 times, most recently from 7a3f8ea to 4328f7e Compare January 10, 2024 15:38
@literat literat force-pushed the dependencies/upgrade-cqt branch from 4328f7e to 9949ffc Compare January 10, 2024 15:56
@literat literat merged commit a4bc522 into main Jan 10, 2024
22 checks passed
@literat literat deleted the dependencies/upgrade-cqt branch January 10, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen left review comments

@adamkudrna adamkudrna adamkudrna approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@literat literat

Labels
blocked Issues blocked by issue we cannot affect maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@literat @coveralls @adamkudrna @crishpeen