Run visual tests also againts local servers #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
literat
requested review from
pavelklibani,
a team,
adamkudrna and
crishpeen
as code owners
literat
commented
Dec 15, 2023
adamkudrna
approved these changes
Dec 19, 2023
crishpeen
reviewed
Dec 19, 2023
crishpeen
requested changes
Dec 21, 2023
There was a problem hiding this comment.
So I tested it and it doesn't work for me. :(
Error: page.goto: net::ERR_CONNECTION_REFUSED at http://localhost:5172/
=========================== logs ===========================
navigating to "http://localhost:5172/", waiting until "load"
Probably the problem with the network URL.
4 tasks
refs #DS-454
refs #DS-1093
literat
force-pushed
the
feat/visual-test-locally
branch
from
37707e1 to
f9e4b16
Compare
crishpeen
reviewed
Jan 2, 2024
crishpeen
approved these changes
Jan 2, 2024
refs #DS-454
refs #DS-454
* the numbers are deprecated * the required version is determined by package.json and yarn.lock
literat
force-pushed
the
feat/visual-test-locally
branch
from
f9e4b16 to
ecf4b82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a new package
spirit-commonwhere are stored shared features, scripts and code.E2E test can be now run against production URLs of development ones. Just set env variable
CItotruefor production urls.Additional context
The visual regression testing will be only run when the
e2elabel is used in PR.Issue reference
https://jira.lmc.cz/browse/DS-1093
Before submitting the PR, please make sure you do the following
fixes #123).