Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding room configuration in SIP dispatch rule #923

Merged
merged 11 commits into from
Dec 25, 2024
6 changes: 6 additions & 0 deletions .changeset/gentle-houses-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"github.com/livekit/protocol": patch
"@livekit/protocol": patch
---

Allow SIP inbound to specify room configuration
793 changes: 423 additions & 370 deletions livekit/livekit_sip.pb.go

Large diffs are not rendered by default.

319 changes: 161 additions & 158 deletions livekit/livekit_sip.twirp.go

Large diffs are not rendered by default.

16 changes: 14 additions & 2 deletions protobufs/livekit_sip.proto
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ option ruby_package = "LiveKit::Proto";
import "google/protobuf/duration.proto";
import "google/protobuf/empty.proto";
import "livekit_models.proto";
import "livekit_room.proto";

/*
LiveKit's SIP API is built with 3 high level primitives
Expand Down Expand Up @@ -385,7 +386,13 @@ message CreateSIPDispatchRuleRequest {
// Participants created by this rule will inherit these attributes.
map<string, string> attributes = 7;

// NEXT ID: 8
// Cloud-only, config preset to use
string room_preset = 8;

// RoomConfiguration to use if the participant initiates the room
RoomConfiguration room_config = 9;

// NEXT ID: 10
}

message SIPDispatchRuleInfo {
Expand All @@ -405,7 +412,12 @@ message SIPDispatchRuleInfo {
// Participants created by this rule will inherit these attributes.
map<string, string> attributes = 8;

// NEXT ID: 9
// Cloud-only, config preset to use
string room_preset = 9;

// RoomConfiguration to use if the participant initiates the room
RoomConfiguration room_config = 10;
// NEXT ID: 11
}

// ListSIPDispatchRuleRequest lists dispatch rules for given filters. If no filters are set, all rules are listed.
Expand Down
32 changes: 16 additions & 16 deletions rpc/participant.psrpc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions rpc/room.psrpc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions rpc/roommanager.psrpc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading