Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding room configuration in SIP dispatch rule #923

Merged
merged 11 commits into from
Dec 25, 2024
Merged

Conversation

davidzhao
Copy link
Member

No description provided.

@davidzhao davidzhao requested review from lukasIO, theomonnom and a team December 15, 2024 19:55
Copy link

changeset-bot bot commented Dec 15, 2024

🦋 Changeset detected

Latest commit: 897d184

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Contributor

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into it a bit more, if we want SIP to set this config on a room, we will need to pass it from IO service to SIP.

This can be done by adding the same parameter to EvaluateSIPDispatchRulesResponse and then passing it along in EvaluateDispatchRule.

@davidzhao
Copy link
Member Author

got it, i'll add them before merging

@davidzhao davidzhao merged commit 2c4895f into main Dec 25, 2024
1 check passed
@davidzhao davidzhao deleted the sip-room-config branch December 25, 2024 21:59
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants