Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding room configuration in SIP dispatch rule #923

Merged
merged 11 commits into from
Dec 25, 2024
6 changes: 6 additions & 0 deletions .changeset/gentle-houses-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"github.com/livekit/protocol": patch
"@livekit/protocol": patch
---

Allow SIP inbound to specify room configuration
2 changes: 1 addition & 1 deletion infra/link.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_agent.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_agent_dispatch.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_analytics.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_egress.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_ingress.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_internal.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_metrics.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_models.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_room.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion livekit/livekit_rtc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

801 changes: 427 additions & 374 deletions livekit/livekit_sip.pb.go

Large diffs are not rendered by default.

321 changes: 162 additions & 159 deletions livekit/livekit_sip.twirp.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion livekit/livekit_webhook.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 14 additions & 2 deletions protobufs/livekit_sip.proto
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ option ruby_package = "LiveKit::Proto";
import "google/protobuf/duration.proto";
import "google/protobuf/empty.proto";
import "livekit_models.proto";
import "livekit_room.proto";

/*
LiveKit's SIP API is built with 3 high level primitives
Expand Down Expand Up @@ -385,7 +386,13 @@ message CreateSIPDispatchRuleRequest {
// Participants created by this rule will inherit these attributes.
map<string, string> attributes = 7;

// NEXT ID: 8
// Cloud-only, config preset to use
string room_preset = 8;

// RoomConfiguration to use if the participant initiates the room
RoomConfiguration room_config = 9;

// NEXT ID: 10
}

message SIPDispatchRuleInfo {
Expand All @@ -405,7 +412,12 @@ message SIPDispatchRuleInfo {
// Participants created by this rule will inherit these attributes.
map<string, string> attributes = 8;

// NEXT ID: 9
// Cloud-only, config preset to use
string room_preset = 9;

// RoomConfiguration to use if the participant initiates the room
RoomConfiguration room_config = 10;
// NEXT ID: 11
}

// ListSIPDispatchRuleRequest lists dispatch rules for given filters. If no filters are set, all rules are listed.
Expand Down
9 changes: 8 additions & 1 deletion protobufs/rpc/io.proto
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ option go_package = "github.com/livekit/protocol/rpc";
import "livekit_egress.proto";
import "livekit_ingress.proto";
import "livekit_sip.proto";
import "livekit_room.proto";
import "google/protobuf/empty.proto";
import "google/protobuf/duration.proto";

Expand Down Expand Up @@ -186,7 +187,13 @@ message EvaluateSIPDispatchRulesResponse {
// Max call duration.
google.protobuf.Duration max_call_duration = 17;

// NEXT ID: 20
// Room preset and config are used only to generate tokens
// once tokens are returned by this response consistently, it will no longer
// be needed
string room_preset = 20;
livekit.RoomConfiguration room_config = 21;

// NEXT ID: 22
}

message UpdateSIPCallStateRequest {
Expand Down
2 changes: 1 addition & 1 deletion rpc/agent.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rpc/agent_dispatch.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rpc/analytics.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rpc/egress.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rpc/ingress.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading