[Fix] Overlapping stored flows #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajoaoff
reviewed
Nov 26, 2021
italovalcy
requested changes
Dec 1, 2021
viniarck
commented
Dec 2, 2021
| return True | ||
|
|
||
|
|
||
| def _match_keys(flow_to_install, stored_flow_dict, flow_to_install_keys): |
There was a problem hiding this comment.
This was extracted to be re-used, but to add support for masked values we'll cover on this issue #24 in the future.
italovalcy
approved these changes
Dec 7, 2021
|
thanks for reviewing, and the second pass Italo and Antonio. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23 that @italovalcy has reported
fix/overlapping_flowsbranch directly on the upstream repo to facilitate visualizing diffs since there are upcoming PRs that will depend on this branch here, let's try this out to see if it facilitates for us)Description of the change
_add_flow_storeto overwrite overlapping flows