-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][cherry-pick] Handle error when switch is not connected #49
Conversation
Co-authored-by: Antonio Francisco <[email protected]>
…_manager into fix/switch_not_connected_2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Thanks for adding a handler for this error, @viniarck .
Thanks @italovalcy and @ajoaoff for your reviews on this PR. This PR is on topf of this one PR #44, I'll merge this one here once PR 44 is reviewed again, if either of you could do a second pass on that on that'd be appreciated. |
Fixes #26
Description of the change
SwitchNotConnectedError
if the switch is not connected and return 424.connection
is no longerNone
.Notice that as mentioned on the dependent PR, there's still cases that we're not handling when the socket TX fails,
flow_manager
willl need to start listening tokytos/core.openflow.connection.error
, but notice that this isn't also being propagated to via the rest request because that's sync, so for clients that need to handle that either they'll have to send an asyncKytosEvent
forkytos.flow_manager.flows.(install|delete)
when we have implemented full error handling, or they can rely on theforce
option that we'll have on issue #46, but that will likely take a lot longer on average - which might or not be a concern - so it'll depends on the responsiveness that the client needs.So, now if a switch isn't connected at the time when the flow mod is about to be sent, clients will get: