[Fix] Overlapping stored flows #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted check_consistency method
- Split _store_changed_flows into smaller specific methods
- Added more test coverage
- Avoided unecessary write in some cases for deletion
viniarck
changed the title
|
I'll close this PR, to change the origin of my branch, I'll push the same branch on this repo, to facilitate visualizing the diffs for other upcoming PRs that will depend on this, that way we can just change the |
|
Closing this in favor of PR #44 (changed the source of the branch to use an upstream branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23 that @italovalcy has reported
Description of the change
_add_flow_storeto overwrite overlapping flows