-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds min package version #912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 tasks
averissimo
force-pushed
the
verdepcheck_action
branch
2 times, most recently
from
September 21, 2023 09:28
957a298
to
ce7b7e6
Compare
Code Coverage Summary
Diff against main
Results for commit: b069692 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
The action is failing for the following strategies:
This will resolve itself once new version of |
averissimo
force-pushed
the
verdepcheck_action
branch
from
October 18, 2023 12:18
ce7b7e6
to
9b36a6a
Compare
pawelru
approved these changes
Nov 22, 2023
averissimo
force-pushed
the
verdepcheck_action
branch
from
November 22, 2023 15:25
3c29c59
to
adbf635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP :: parent issue: insightsengineering/nestdevs-tasks#7
🔴 Checklist for PR Reviewer
(
max
andrelease
strategies are expected to fail... see below)main
rmarkdown
(may have been removed onSuggests
)Imports
,Depends
&Suggests
are in new sectionConfig/Needs/verdepcheck
NEWS.md
scheduled.yaml
action was run succesfully (all 4 strategies)Scheduled 🕰️ / Dependency
actionsscheduled.yaml
SHOULD NOT have any push on any branches🔴 What's needed before merging?
This PR depends on some upstream changes that need to be finalized/merged before being ready to review.
Change in code
verdepcheck.yml
action (see comments)on: push
sectionPRS
min_isolated
andmin_cohort
r-verdepcheck-action#16Changes description
DESCRIPTION
Config/Need/verdepcheck
section inDESCRIPTION