Skip to content

Commit

Permalink
Adds min package version (#912)
Browse files Browse the repository at this point in the history
WIP :: parent issue:
insightsengineering/nestdevs-tasks#7

### 🔴 Checklist for PR Reviewer

[![Scheduled
🕰️](https://github.com/insightsengineering/teal/actions/workflows/scheduled.yaml/badge.svg?branch=verdepcheck_action)](https://github.com/insightsengineering/teal/actions/workflows/scheduled.yaml?query=branch%3Averdepcheck_action)
_(`max` and `release` strategies are expected to fail... see below)_

- [ ] Tag yourself next to this repo on
insightsengineering/nestdevs-tasks#7
- [ ] Package versions are the same or higher than `main`
- [ ] Package list is the same
  - Only exception is `rmarkdown` (may have been removed on `Suggests`)
- [ ] All packages in `Imports`, `Depends` & `Suggests` are in new
section `Config/Needs/verdepcheck`
- [ ] Added entry to `NEWS.md`
- [ ] Last `scheduled.yaml` action was run succesfully _(all 4
strategies)_
- important: it's not the last commit, it's the one that runs 4
`Scheduled 🕰️ / Dependency` actions
- [ ] `scheduled.yaml` SHOULD NOT have any push on any branches

### 🔴 What's needed before merging?

This PR depends on some upstream changes that need to be
finalized/merged before being ready to review.

#### Change in code

* `verdepcheck.yml` action (see comments)
  - [x] Remove `on: push` section 
  - [x] Change branch to main

#### PRS

- [x] verdepcheck
  * insightsengineering/verdepcheck#24
  * insightsengineering/verdepcheck#26
- [x] verdepcheck-action
  * insightsengineering/r-verdepcheck-action#16

### Changes description

* Adds minimum version for packages `DESCRIPTION`
* Adds `Config/Need/verdepcheck` section in `DESCRIPTION`
* Updates verdepcheck action
  • Loading branch information
averissimo authored Nov 22, 2023
1 parent 0d012df commit 669c172
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
test-strategy: ["min", "release", "max"]
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
secrets:
Expand Down
45 changes: 36 additions & 9 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ Depends:
teal.slice (>= 0.4.0.9023),
teal.transform (>= 0.4.0.9007)
Imports:
checkmate,
checkmate (>= 2.1.0),
jsonlite,
lifecycle,
lifecycle (>= 0.2.0),
logger (>= 0.2.0),
magrittr,
rlang,
magrittr (>= 1.5),
rlang (>= 1.0.0),
shinyjs,
stats,
teal.logger (>= 0.1.1),
Expand All @@ -50,20 +50,47 @@ Imports:
Suggests:
bslib,
covr,
dplyr,
knitr,
dplyr (>= 1.0.5),
knitr (>= 1.42),
MultiAssayExperiment,
R6,
rmarkdown,
rmarkdown (>= 2.19),
shinyvalidate,
teal.code (>= 0.3.0.9009),
testthat (>= 3.1.5),
withr,
yaml
withr (>= 2.1.0),
yaml (>= 1.1.0)
VignetteBuilder:
knitr
RdMacros:
lifecycle
Config/Needs/verdepcheck:
rstudio/shiny,
insightsengineering/teal.data,
insightsengineering/teal.slice,
insightsengineering/teal.transform,
mllg/checkmate,
jeroen/jsonlite,
r-lib/lifecycle,
daroczig/logger,
tidyverse/magrittr,
r-lib/rlang,
daattali/shinyjs,
insightsengineering/teal.logger,
insightsengineering/teal.reporter,
insightsengineering/teal.widgets,
rstudio/bslib,
r-lib/covr,
tidyverse/dplyr,
yihui/knitr,
bioc::MultiAssayExperiment,
r-lib/R6,
rstudio/rmarkdown,
rstudio/shinyvalidate,
insightsengineering/teal.code,
r-lib/testthat,
r-lib/withr,
yaml=vubiostat/r-yaml
Config/Needs/website: insightsengineering/nesttemplate
Encoding: UTF-8
Language: en-US
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
### Bug fixes

* Removed `Report previewer` module from mapping matrix display in filter manager.
* Specified minimal version of package dependencies.

# teal 0.14.0

Expand Down

0 comments on commit 669c172

Please sign in to comment.